From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbbLNIPH (ORCPT ); Mon, 14 Dec 2015 03:15:07 -0500 Received: from terminus.zytor.com ([198.137.202.10]:52170 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbbLNIPE (ORCPT ); Mon, 14 Dec 2015 03:15:04 -0500 Date: Mon, 14 Dec 2015 00:14:50 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: namhyung@kernel.org, linux-kernel@vger.kernel.org, jolsa@redhat.com, dsahern@gmail.com, acme@redhat.com, a.p.zijlstra@chello.nl, tglx@linutronix.de, jpoimboe@redhat.com, hpa@zytor.com, mingo@kernel.org Reply-To: namhyung@kernel.org, linux-kernel@vger.kernel.org, jolsa@redhat.com, acme@redhat.com, dsahern@gmail.com, a.p.zijlstra@chello.nl, tglx@linutronix.de, jpoimboe@redhat.com, hpa@zytor.com, mingo@kernel.org In-Reply-To: <1449716459-23004-8-git-send-email-namhyung@kernel.org> References: <1449716459-23004-8-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Get rid of exit_browser() from usage_with_options() Git-Commit-ID: 3f86eb6b0771d785099c91354838d3f8d8126630 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3f86eb6b0771d785099c91354838d3f8d8126630 Gitweb: http://git.kernel.org/tip/3f86eb6b0771d785099c91354838d3f8d8126630 Author: Namhyung Kim AuthorDate: Thu, 10 Dec 2015 12:00:59 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 10 Dec 2015 15:47:52 -0300 perf tools: Get rid of exit_browser() from usage_with_options() Since all of its users call before setup_browser(), there's no need to call exit_browser() inside of the function. Signed-off-by: Namhyung Kim Reviewed-by: Josh Poimboeuf Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1449716459-23004-8-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/parse-options.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c index d09aff9..de3290b 100644 --- a/tools/perf/util/parse-options.c +++ b/tools/perf/util/parse-options.c @@ -766,7 +766,6 @@ int usage_with_options_internal(const char * const *usagestr, void usage_with_options(const char * const *usagestr, const struct option *opts) { - exit_browser(false); usage_with_options_internal(usagestr, opts, 0, NULL); exit(129); } @@ -776,8 +775,6 @@ void usage_with_options_msg(const char * const *usagestr, { va_list ap; - exit_browser(false); - va_start(ap, fmt); strbuf_addv(&error_buf, fmt, ap); va_end(ap);