From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936553AbcJVIoX (ORCPT ); Sat, 22 Oct 2016 04:44:23 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57278 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932756AbcJVIoT (ORCPT ); Sat, 22 Oct 2016 04:44:19 -0400 Date: Sat, 22 Oct 2016 01:44:06 -0700 From: tip-bot for Jiri Olsa Message-ID: Cc: acme@redhat.com, dsahern@gmail.com, tglx@linutronix.de, hpa@zytor.com, a.p.zijlstra@chello.nl, mingo@kernel.org, namhyung@kernel.org, dzickus@redhat.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, jmario@redhat.com, jolsa@kernel.org Reply-To: a.p.zijlstra@chello.nl, hpa@zytor.com, tglx@linutronix.de, acme@redhat.com, dsahern@gmail.com, jolsa@kernel.org, jmario@redhat.com, andi@firstfloor.org, linux-kernel@vger.kernel.org, dzickus@redhat.com, namhyung@kernel.org, mingo@kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf c2c report: Add 'pid' sort key Git-Commit-ID: 36d3deb9d6d7f5f3b0b1dbb3398c413e4521af64 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 36d3deb9d6d7f5f3b0b1dbb3398c413e4521af64 Gitweb: http://git.kernel.org/tip/36d3deb9d6d7f5f3b0b1dbb3398c413e4521af64 Author: Jiri Olsa AuthorDate: Tue, 24 May 2016 13:09:47 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 19 Oct 2016 13:18:31 -0300 perf c2c report: Add 'pid' sort key It is to be displayed in the single cacheline output: pid We currently don't have a single 'pid' sort/display entry, which would output just pid number, hence adding it into c2c code. Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: David Ahern Cc: Don Zickus Cc: Joe Mario Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-3o23qrspxc99b04ci1swlzr6@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-c2c.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index c718d8b..4795713 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -810,6 +810,22 @@ percent_stores_l1miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused, STAT_FN(lcl_dram) STAT_FN(rmt_dram) +static int +pid_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, + struct hist_entry *he) +{ + int width = c2c_width(fmt, hpp, he->hists); + + return scnprintf(hpp->buf, hpp->size, "%*d", width, he->thread->pid_); +} + +static int64_t +pid_cmp(struct perf_hpp_fmt *fmt __maybe_unused, + struct hist_entry *left, struct hist_entry *right) +{ + return left->thread->pid_ - right->thread->pid_; +} + #define HEADER_LOW(__h) \ { \ .line[1] = { \ @@ -1074,6 +1090,14 @@ static struct c2c_dimension dim_dram_rmt = { .width = 8, }; +static struct c2c_dimension dim_pid = { + .header = HEADER_LOW("Pid"), + .name = "pid", + .cmp = pid_cmp, + .entry = pid_entry, + .width = 7, +}; + static struct c2c_dimension *dimensions[] = { &dim_dcacheline, &dim_offset, @@ -1103,6 +1127,7 @@ static struct c2c_dimension *dimensions[] = { &dim_percent_stores_l1miss, &dim_dram_lcl, &dim_dram_rmt, + &dim_pid, NULL, };