From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbeAKGVi (ORCPT + 1 other); Thu, 11 Jan 2018 01:21:38 -0500 Received: from terminus.zytor.com ([65.50.211.136]:52799 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbeAKGVg (ORCPT ); Thu, 11 Jan 2018 01:21:36 -0500 Date: Wed, 10 Jan 2018 22:19:09 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: tglx@linutronix.de, jolsa@kernel.org, acme@redhat.com, namhyung@kernel.org, wangnan0@huawei.com, mingo@kernel.org, adrian.hunter@intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dsahern@gmail.com Reply-To: linux-kernel@vger.kernel.org, dsahern@gmail.com, namhyung@kernel.org, wangnan0@huawei.com, adrian.hunter@intel.com, mingo@kernel.org, hpa@zytor.com, jolsa@kernel.org, acme@redhat.com, tglx@linutronix.de To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf test bpf: Improve message about expected samples Git-Commit-ID: 6703c9771d83ebe092b0d49cb0609a3f9d8b4ff7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 6703c9771d83ebe092b0d49cb0609a3f9d8b4ff7 Gitweb: https://git.kernel.org/tip/6703c9771d83ebe092b0d49cb0609a3f9d8b4ff7 Author: Arnaldo Carvalho de Melo AuthorDate: Tue, 2 Jan 2018 14:59:21 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 8 Jan 2018 11:11:56 -0300 perf test bpf: Improve message about expected samples When failing on one of the BPF tests we were just stating: BPF filter result incorrect Add some more info to help figuring out the problem: BPF filter result incorrect, expected 56, got 0 samples This came out while investigating this failure, first seen after updating the kernel to the 4.15.0-rc6 tag: [root@jouet ~]# perf test bpf 39: BPF filter : 39.1: Basic BPF filtering : FAILED! 39.2: BPF pinning : Skip 39.3: BPF prologue generation: Skip 39.4: BPF relocation checker : Skip [root@jouet ~]# Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-403npu7daupv6b2bmxliv5pk@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c index c433dd3..057c6b8 100644 --- a/tools/perf/tests/bpf.c +++ b/tools/perf/tests/bpf.c @@ -190,7 +190,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void), } if (count != expect) { - pr_debug("BPF filter result incorrect\n"); + pr_debug("BPF filter result incorrect, expected %d, got %d samples\n", expect, count); goto out_delete_evlist; }