From: tip-bot for Ben Hutchings <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, ben@decadent.org.uk, acme@redhat.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@kernel.org, peterz@infradead.org
Subject: [tip:perf/urgent] perf symbols: Fix reading of build-id from vDSO
Date: Tue, 19 Jan 2016 05:34:28 -0800 [thread overview]
Message-ID: <tip-40c4a0f92aed570cc529a1e5c24c7e04a0ce8b85@git.kernel.org> (raw)
In-Reply-To: <20160113172301.GT28542@decadent.org.uk>
Commit-ID: 40c4a0f92aed570cc529a1e5c24c7e04a0ce8b85
Gitweb: http://git.kernel.org/tip/40c4a0f92aed570cc529a1e5c24c7e04a0ce8b85
Author: Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Wed, 13 Jan 2016 17:23:01 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Jan 2016 16:31:58 -0300
perf symbols: Fix reading of build-id from vDSO
We need to use the long name (the filename) when reading the build-id
from a DSO. Using the short name doesn't work for (at least) vDSOs.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160113172301.GT28542@decadent.org.uk
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 3b2de6e..ab02209 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1466,7 +1466,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter)
* Read the build id if possible. This is required for
* DSO_BINARY_TYPE__BUILDID_DEBUGINFO to work
*/
- if (filename__read_build_id(dso->name, build_id, BUILD_ID_SIZE) > 0)
+ if (filename__read_build_id(dso->long_name, build_id, BUILD_ID_SIZE) > 0)
dso__set_build_id(dso, build_id);
/*
prev parent reply other threads:[~2016-01-19 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:23 [PATCH] perf tools: " Ben Hutchings
2016-01-13 19:51 ` Arnaldo Carvalho de Melo
2016-01-19 13:34 ` tip-bot for Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-40c4a0f92aed570cc529a1e5c24c7e04a0ce8b85@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ben@decadent.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome