From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757736AbdJPVU3 (ORCPT ); Mon, 16 Oct 2017 17:20:29 -0400 Received: from terminus.zytor.com ([65.50.211.136]:40393 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755344AbdJPVU1 (ORCPT ); Mon, 16 Oct 2017 17:20:27 -0400 Date: Mon, 16 Oct 2017 14:16:46 -0700 From: "tip-bot for mike.travis@hpe.com" Message-ID: Cc: tglx@linutronix.de, bin.gao@linux.intel.com, dimitri.sivanich@hpe.com, andrew.banman@hpe.com, mingo@kernel.org, mike.travis@hpe.com, prarit@redhat.com, peterz@infradead.org, hpa@zytor.com, russ.anderson@hpe.com, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, russ.anderson@hpe.com, andrew.banman@hpe.com, mingo@kernel.org, mike.travis@hpe.com, tglx@linutronix.de, bin.gao@linux.intel.com, dimitri.sivanich@hpe.com, peterz@infradead.org, prarit@redhat.com In-Reply-To: <20171012163202.175062400@stormcage.americas.sgi.com> References: <20171012163202.175062400@stormcage.americas.sgi.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/timers] x86/tsc: Drastically reduce the number of firmware bug warnings Git-Commit-ID: 41e7864ab5ce4ec36e89a9f55d8d9dfe19b0392c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 41e7864ab5ce4ec36e89a9f55d8d9dfe19b0392c Gitweb: https://git.kernel.org/tip/41e7864ab5ce4ec36e89a9f55d8d9dfe19b0392c Author: mike.travis@hpe.com AuthorDate: Thu, 12 Oct 2017 11:32:04 -0500 Committer: Thomas Gleixner CommitDate: Mon, 16 Oct 2017 22:50:36 +0200 x86/tsc: Drastically reduce the number of firmware bug warnings Prior to the TSC ADJUST MSR being available, the method to set TSC's in sync with each other naturally caused a small skew between cpu threads. This was NOT a firmware bug at the time so introducing a whole avalanche of alarming warning messages might cause unnecessary concern and customer complaints. (Example: >3000 msgs in a 32 socket Skylake system.) Simply report the warning condition, if possible do the necessary fixes, and move on. Signed-off-by: Mike Travis Signed-off-by: Thomas Gleixner Reviewed-by: Dimitri Sivanich Reviewed-by: Russ Anderson Reviewed-by: Peter Zijlstra Cc: Prarit Bhargava Cc: Andrew Banman Cc: Bin Gao Link: https://lkml.kernel.org/r/20171012163202.175062400@stormcage.americas.sgi.com --- arch/x86/kernel/tsc_sync.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c index 3bdb983..26ba053 100644 --- a/arch/x86/kernel/tsc_sync.c +++ b/arch/x86/kernel/tsc_sync.c @@ -177,10 +177,9 @@ bool tsc_store_and_check_tsc_adjust(bool bootcpu) * Compare the boot value and complain if it differs in the * package. */ - if (bootval != ref->bootval) { - pr_warn(FW_BUG "TSC ADJUST differs: Reference CPU%u: %lld CPU%u: %lld\n", - refcpu, ref->bootval, cpu, bootval); - } + if (bootval != ref->bootval) + printk_once(FW_BUG "TSC ADJUST differs within socket(s), fixing all errors\n"); + /* * The TSC_ADJUST values in a package must be the same. If the boot * value on this newly upcoming CPU differs from the adjustment @@ -188,8 +187,6 @@ bool tsc_store_and_check_tsc_adjust(bool bootcpu) * adjusted value. */ if (bootval != ref->adjusted) { - pr_warn("TSC ADJUST synchronize: Reference CPU%u: %lld CPU%u: %lld\n", - refcpu, ref->adjusted, cpu, bootval); cur->adjusted = ref->adjusted; wrmsrl(MSR_IA32_TSC_ADJUST, ref->adjusted); }