From: tip-bot for Nikolas Nyby <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: nikolas@gnu.org, tglx@linutronix.de, hpa@zytor.com,
mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip:x86/cleanups] x86/crash: Remove unnecessary comparison
Date: Wed, 24 Jul 2019 07:55:14 -0700 [thread overview]
Message-ID: <tip-4599c6671b8119ed5455e4ed6b967b461c27a9f7@git.kernel.org> (raw)
In-Reply-To: <20190724041337.8346-1-nikolas@gnu.org>
Commit-ID: 4599c6671b8119ed5455e4ed6b967b461c27a9f7
Gitweb: https://git.kernel.org/tip/4599c6671b8119ed5455e4ed6b967b461c27a9f7
Author: Nikolas Nyby <nikolas@gnu.org>
AuthorDate: Wed, 24 Jul 2019 00:13:37 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 24 Jul 2019 16:50:15 +0200
x86/crash: Remove unnecessary comparison
The ret comparison and return are unnecessary as of commit f296f2634920
("x86/kexec: Remove walk_iomem_res() call with GART type")
elf_header_exclude_ranges() returns ret in any case, with or without this
comparison.
[ tglx: Use a proper commit reference instead of full SHA ]
Signed-off-by: Nikolas Nyby <nikolas@gnu.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190724041337.8346-1-nikolas@gnu.org
---
arch/x86/kernel/crash.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 2bf70a2fed90..eb651fbde92a 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -225,8 +225,6 @@ static int elf_header_exclude_ranges(struct crash_mem *cmem)
if (crashk_low_res.end) {
ret = crash_exclude_mem_range(cmem, crashk_low_res.start,
crashk_low_res.end);
- if (ret)
- return ret;
}
return ret;
prev parent reply other threads:[~2019-07-24 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:13 [PATCH] x86/crash: remove " Nikolas Nyby
2019-07-24 14:55 ` tip-bot for Nikolas Nyby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4599c6671b8119ed5455e4ed6b967b461c27a9f7@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikolas@gnu.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome