From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, jolsa@redhat.com, acme@redhat.com,
dsahern@gmail.com, peterz@infradead.org, mingo@kernel.org,
tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
eranian@google.com
Subject: [tip:perf/urgent] perf tools: Fixup off-by-one comparision in maps__find
Date: Wed, 15 Oct 2014 03:05:59 -0700 [thread overview]
Message-ID: <tip-4955ea225db42144d1667838f908315a16d51c5b@git.kernel.org> (raw)
In-Reply-To: <8761fwh1nc.fsf@sejong.aot.lge.com>
Commit-ID: 4955ea225db42144d1667838f908315a16d51c5b
Gitweb: http://git.kernel.org/tip/4955ea225db42144d1667838f908315a16d51c5b
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 14 Oct 2014 16:05:38 -0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 14 Oct 2014 17:50:56 -0300
perf tools: Fixup off-by-one comparision in maps__find
map->end is the first addr _outside_ the a map, following the convention
of vm_area_struct->vm_end.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/8761fwh1nc.fsf@sejong.aot.lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/map.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 186418b..2137c45 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -752,7 +752,7 @@ struct map *maps__find(struct rb_root *maps, u64 ip)
m = rb_entry(parent, struct map, rb_node);
if (ip < m->start)
p = &(*p)->rb_left;
- else if (ip > m->end)
+ else if (ip >= m->end)
p = &(*p)->rb_right;
else
return m;
next prev parent reply other threads:[~2014-10-15 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 8:35 [PATCH v2] perf tools: fix off-by-one error in maps Stephane Eranian
2014-10-07 5:47 ` Namhyung Kim
2014-10-07 8:40 ` Stephane Eranian
2014-10-07 14:00 ` Arnaldo Carvalho de Melo
2014-10-07 14:17 ` Stephane Eranian
2014-10-07 15:10 ` Arnaldo Carvalho de Melo
2014-10-07 15:17 ` Stephane Eranian
2014-10-14 18:58 ` Arnaldo Carvalho de Melo
2014-10-14 19:03 ` Stephane Eranian
2014-10-14 19:24 ` Arnaldo Carvalho de Melo
2014-10-07 18:58 ` Chuck Ebbert
2014-10-08 15:53 ` Arnaldo Carvalho de Melo
2014-10-14 19:04 ` Arnaldo Carvalho de Melo
2014-10-15 10:05 ` tip-bot for Namhyung Kim [this message]
2014-10-15 10:05 ` [tip:perf/urgent] " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4955ea225db42144d1667838f908315a16d51c5b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome