From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbcFZLB0 (ORCPT ); Sun, 26 Jun 2016 07:01:26 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51530 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbcFZLBY (ORCPT ); Sun, 26 Jun 2016 07:01:24 -0400 Date: Sun, 26 Jun 2016 04:00:50 -0700 From: tip-bot for Taeung Song Message-ID: Cc: jolsa@kernel.org, hpa@zytor.com, alexander.shishkin@linux.intel.com, mhiramat@kernel.org, wangnan0@huawei.com, peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@kernel.org, treeze.taeung@gmail.com, acme@redhat.com, namhyung@kernel.org, tglx@linutronix.de Reply-To: wangnan0@huawei.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, acme@redhat.com, tglx@linutronix.de, namhyung@kernel.org, treeze.taeung@gmail.com, jolsa@kernel.org, mhiramat@kernel.org, alexander.shishkin@linux.intel.com, hpa@zytor.com In-Reply-To: <1466691272-24117-4-git-send-email-treeze.taeung@gmail.com> References: <1466691272-24117-4-git-send-email-treeze.taeung@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf config: Reimplement show_config() using config_set__for_each Git-Commit-ID: 4a35b3497c413de8b409f9d75700eeb4772b21b8 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4a35b3497c413de8b409f9d75700eeb4772b21b8 Gitweb: http://git.kernel.org/tip/4a35b3497c413de8b409f9d75700eeb4772b21b8 Author: Taeung Song AuthorDate: Thu, 23 Jun 2016 23:14:32 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 23 Jun 2016 17:23:00 -0300 perf config: Reimplement show_config() using config_set__for_each Recently config_set__for_each got added. In order to let show_config() be short and clear, rewrite this function using it. Signed-off-by: Taeung Song Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/1466691272-24117-4-git-send-email-treeze.taeung@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-config.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index cfd1036..e4207a2 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@ -37,23 +37,16 @@ static int show_config(struct perf_config_set *set) { struct perf_config_section *section; struct perf_config_item *item; - struct list_head *sections; if (set == NULL) return -1; - sections = &set->sections; - if (list_empty(sections)) - return -1; - - list_for_each_entry(section, sections, node) { - list_for_each_entry(item, §ion->items, node) { - char *value = item->value; + perf_config_set__for_each_entry(set, section, item) { + char *value = item->value; - if (value) - printf("%s.%s=%s\n", section->name, - item->name, value); - } + if (value) + printf("%s.%s=%s\n", section->name, + item->name, value); } return 0;