From: "tip-bot for Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
srivatsa.bhat@linux.vnet.ibm.com, tglx@linutronix.de
Subject: [tip:smp/hotplug] smpboot, idle: Fix comment mismatch over idle_threads_init()
Date: Thu, 24 May 2012 14:05:20 -0700 [thread overview]
Message-ID: <tip-4a70d2d9909b43ed88043b98cabe2c7fbd563021@git.kernel.org> (raw)
In-Reply-To: <20120524151100.2549.66501.stgit@srivatsabhat.in.ibm.com>
Commit-ID: 4a70d2d9909b43ed88043b98cabe2c7fbd563021
Gitweb: http://git.kernel.org/tip/4a70d2d9909b43ed88043b98cabe2c7fbd563021
Author: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
AuthorDate: Thu, 24 May 2012 20:41:00 +0530
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 24 May 2012 22:58:08 +0200
smpboot, idle: Fix comment mismatch over idle_threads_init()
The comment over idle_threads_init() really talks about the functionality
of idle_init(). Move that comment to idle_init(), and add a suitable
comment over idle_threads_init().
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: suresh.b.siddha@intel.com
Cc: venki@google.com
Cc: nikunj@linux.vnet.ibm.com
Link: http://lkml.kernel.org/r/20120524151100.2549.66501.stgit@srivatsabhat.in.ibm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/smpboot.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/kernel/smpboot.c b/kernel/smpboot.c
index 0f2162f..98f60c5 100644
--- a/kernel/smpboot.c
+++ b/kernel/smpboot.c
@@ -31,6 +31,12 @@ void __init idle_thread_set_boot_cpu(void)
per_cpu(idle_threads, smp_processor_id()) = current;
}
+/**
+ * idle_init - Initialize the idle thread for a cpu
+ * @cpu: The cpu for which the idle thread should be initialized
+ *
+ * Creates the thread if it does not exist.
+ */
static inline void idle_init(unsigned int cpu)
{
struct task_struct *tsk = per_cpu(idle_threads, cpu);
@@ -45,10 +51,7 @@ static inline void idle_init(unsigned int cpu)
}
/**
- * idle_thread_init - Initialize the idle thread for a cpu
- * @cpu: The cpu for which the idle thread should be initialized
- *
- * Creates the thread if it does not exist.
+ * idle_threads_init - Initialize idle threads for all cpus
*/
void __init idle_threads_init(void)
{
next prev parent reply other threads:[~2012-05-24 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 15:10 [PATCH 1/2] smpboot, idle: Optimize calls to smp_processor_id() in idle_threads_init() Srivatsa S. Bhat
2012-05-24 15:11 ` [PATCH 2/2] smpboot, idle: Fix comment mismatch over idle_threads_init() Srivatsa S. Bhat
2012-05-24 21:05 ` tip-bot for Srivatsa S. Bhat [this message]
2012-05-24 21:04 ` [tip:smp/hotplug] smpboot, idle: Optimize calls to smp_processor_id() in idle_threads_init() tip-bot for Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4a70d2d9909b43ed88043b98cabe2c7fbd563021@git.kernel.org \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome