mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Alexandre Belloni <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: monstr@monstr.eu, hpa@zytor.com,
	alexandre.belloni@free-electrons.com, tglx@linutronix.de,
	sboyd@codeaurora.org, john.stultz@linaro.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [tip:timers/core] alarmtimer: Ensure RTC module is not unloaded
Date: Thu, 31 Aug 2017 12:40:28 -0700	[thread overview]
Message-ID: <tip-51218298a25e6942957c5595f2abf130d47d5df9@git.kernel.org> (raw)
In-Reply-To: <20170820220146.30969-1-alexandre.belloni@free-electrons.com>

Commit-ID:  51218298a25e6942957c5595f2abf130d47d5df9
Gitweb:     http://git.kernel.org/tip/51218298a25e6942957c5595f2abf130d47d5df9
Author:     Alexandre Belloni <alexandre.belloni@free-electrons.com>
AuthorDate: Mon, 21 Aug 2017 00:01:46 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 31 Aug 2017 21:36:45 +0200

alarmtimer: Ensure RTC module is not unloaded

When registering the rtc device to be used to handle alarm timers,
get_device is used to ensure the device doesn't go away but the module can
still be unloaded.

Call try_module_get to ensure the rtc driver will not go away.

Reported-and-tested-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: John Stultz <john.stultz@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Link: http://lkml.kernel.org/r/20170820220146.30969-1-alexandre.belloni@free-electrons.com

---
 kernel/time/alarmtimer.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 73a2b47..ec09ce9 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -28,6 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/freezer.h>
 #include <linux/compat.h>
+#include <linux/module.h>
 
 #include "posix-timers.h"
 
@@ -103,6 +104,11 @@ static int alarmtimer_rtc_add_device(struct device *dev,
 
 	spin_lock_irqsave(&rtcdev_lock, flags);
 	if (!rtcdev) {
+		if (!try_module_get(rtc->owner)) {
+			spin_unlock_irqrestore(&rtcdev_lock, flags);
+			return -1;
+		}
+
 		rtcdev = rtc;
 		/* hold a reference so it doesn't go away */
 		get_device(dev);

      parent reply	other threads:[~2017-08-31 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20 22:01 [PATCH] alarmtimer: ensure " Alexandre Belloni
2017-08-21  9:42 ` Michal Simek
2017-08-31 19:40 ` tip-bot for Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-51218298a25e6942957c5595f2abf130d47d5df9@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=monstr@monstr.eu \
    --cc=sboyd@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®