From: tip-bot for Marc Zyngier <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: marc.zyngier@arm.com, tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: [tip:irq/core] genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file
Date: Mon, 1 Oct 2018 03:27:54 -0700 [thread overview]
Message-ID: <tip-513145ea66af95f1a5c744d7b5a4f4a97625e669@git.kernel.org> (raw)
In-Reply-To: <20181001100522.180054-2-marc.zyngier@arm.com>
Commit-ID: 513145ea66af95f1a5c744d7b5a4f4a97625e669
Gitweb: https://git.kernel.org/tip/513145ea66af95f1a5c744d7b5a4f4a97625e669
Author: Marc Zyngier <marc.zyngier@arm.com>
AuthorDate: Mon, 1 Oct 2018 11:05:21 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 1 Oct 2018 12:24:53 +0200
genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file
When removing a debugfs file for a given irq domain, we fail to clear the
corresponding field, meaning that the corresponding domain won't be created
again if we need to do so.
It turns out that this is exactly what irq_domain_update_bus_token does
(delete old file, update domain name, recreate file).
This doesn't have any impact other than making debug more difficult, but we
do value ease of debugging... So clear the debugfs_file field.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20181001100522.180054-2-marc.zyngier@arm.com
---
kernel/irq/irqdomain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 5d9fc01b60a6..95a0acbdd4e6 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1741,6 +1741,7 @@ static void debugfs_add_domain_dir(struct irq_domain *d)
static void debugfs_remove_domain_dir(struct irq_domain *d)
{
debugfs_remove(d->debugfs_file);
+ d->debugfs_file = NULL;
}
void __init irq_domain_debugfs_init(struct dentry *root)
next prev parent reply other threads:[~2018-10-01 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 10:05 [PATCH 0/2] irqdomain debufs fixes for 4.20 Marc Zyngier
2018-10-01 10:05 ` [PATCH 1/2] genirq/debugfs: Reset domain debugfs_file on removal of the debugfs file Marc Zyngier
2018-10-01 10:27 ` tip-bot for Marc Zyngier [this message]
2018-10-01 10:05 ` [PATCH 2/2] genirq/debugfs: Reinstate full OF path for domain name Marc Zyngier
2018-10-01 10:28 ` [tip:irq/core] " tip-bot for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-513145ea66af95f1a5c744d7b5a4f4a97625e669@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®