From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbbJUKG7 (ORCPT ); Wed, 21 Oct 2015 06:06:59 -0400 Received: from terminus.zytor.com ([198.137.202.10]:42197 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbbJUKG4 (ORCPT ); Wed, 21 Oct 2015 06:06:56 -0400 Date: Wed, 21 Oct 2015 03:06:07 -0700 From: tip-bot for Borislav Petkov Message-ID: Cc: hpa@zytor.com, bhe@redhat.com, mingo@kernel.org, luto@amacapital.net, torvalds@linux-foundation.org, akpm@linux-foundation.org, dyoung@redhat.com, tglx@linutronix.de, jgross@suse.com, bp@suse.de, linux-kernel@vger.kernel.org, vgoyal@redhat.com, jroedel@suse.de, peterz@infradead.org, jkosina@suse.cz, chaowang@redhat.com, msalter@redhat.com Reply-To: jkosina@suse.cz, peterz@infradead.org, msalter@redhat.com, chaowang@redhat.com, jgross@suse.com, jroedel@suse.de, vgoyal@redhat.com, linux-kernel@vger.kernel.org, bp@suse.de, dyoung@redhat.com, akpm@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, bhe@redhat.com, hpa@zytor.com, torvalds@linux-foundation.org, luto@amacapital.net In-Reply-To: <1445246268-26285-8-git-send-email-bp@alien8.de> References: <1445246268-26285-8-git-send-email-bp@alien8.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:ras/core] kexec/crash: Say which char is the unrecognized Git-Commit-ID: 53b90c0c56b502056da83d768047dcf765bac9fb X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 53b90c0c56b502056da83d768047dcf765bac9fb Gitweb: http://git.kernel.org/tip/53b90c0c56b502056da83d768047dcf765bac9fb Author: Borislav Petkov AuthorDate: Mon, 19 Oct 2015 11:17:47 +0200 Committer: Ingo Molnar CommitDate: Wed, 21 Oct 2015 11:10:57 +0200 kexec/crash: Say which char is the unrecognized It is helpful when the crashkernel cmdline parsing routines actually say which character is the unrecognized one. Make them do so. Signed-off-by: Borislav Petkov Reviewed-by: Dave Young Reviewed-by: Joerg Roedel Cc: Andrew Morton Cc: Andy Lutomirski Cc: Baoquan He Cc: H. Peter Anvin Cc: Jiri Kosina Cc: Juergen Gross Cc: Linus Torvalds Cc: Mark Salter Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Vivek Goyal Cc: WANG Chao Cc: jerry_hoemann@hp.com Link: http://lkml.kernel.org/r/1445246268-26285-8-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar --- kernel/kexec_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 201b453..bd9f8a0 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1149,7 +1149,7 @@ static int __init parse_crashkernel_simple(char *cmdline, if (*cur == '@') *crash_base = memparse(cur+1, &cur); else if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } @@ -1186,12 +1186,12 @@ static int __init parse_crashkernel_suffix(char *cmdline, /* check with suffix */ if (strncmp(cur, suffix, strlen(suffix))) { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } cur += strlen(suffix); if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; }