From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933896AbeAJIEy (ORCPT + 1 other); Wed, 10 Jan 2018 03:04:54 -0500 Received: from terminus.zytor.com ([65.50.211.136]:44297 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbeAJIEw (ORCPT ); Wed, 10 Jan 2018 03:04:52 -0500 Date: Tue, 9 Jan 2018 23:54:40 -0800 From: tip-bot for Mathieu Desnoyers Message-ID: Cc: paulmck@linux.vnet.ibm.com, benh@kernel.crashing.org, mingo@kernel.org, parri.andrea@gmail.com, torvalds@linux-foundation.org, davejwatson@fb.com, hpa@zytor.com, maged.michael@gmail.com, ahh@google.com, mpe@ellerman.id.au, linux-kernel@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de, paulus@samba.org, boqun.feng@gmail.com, mathieu.desnoyers@efficios.com, avi@scylladb.com Reply-To: benh@kernel.crashing.org, mingo@kernel.org, paulmck@linux.vnet.ibm.com, parri.andrea@gmail.com, davejwatson@fb.com, torvalds@linux-foundation.org, ahh@google.com, hpa@zytor.com, maged.michael@gmail.com, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, peterz@infradead.org, tglx@linutronix.de, boqun.feng@gmail.com, paulus@samba.org, mathieu.desnoyers@efficios.com, avi@scylladb.com In-Reply-To: <20171215192310.25293-1-mathieu.desnoyers@efficios.com> References: <20171215192310.25293-1-mathieu.desnoyers@efficios.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/urgent] membarrier: Disable preemption when calling smp_call_function_many() Git-Commit-ID: 541676078b52f365f53d46ee5517d305cd1b6350 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 541676078b52f365f53d46ee5517d305cd1b6350 Gitweb: https://git.kernel.org/tip/541676078b52f365f53d46ee5517d305cd1b6350 Author: Mathieu Desnoyers AuthorDate: Fri, 15 Dec 2017 14:23:10 -0500 Committer: Ingo Molnar CommitDate: Wed, 10 Jan 2018 08:50:31 +0100 membarrier: Disable preemption when calling smp_call_function_many() smp_call_function_many() requires disabling preemption around the call. Signed-off-by: Mathieu Desnoyers Cc: # v4.14+ Cc: Andrea Parri Cc: Andrew Hunter Cc: Avi Kivity Cc: Benjamin Herrenschmidt Cc: Boqun Feng Cc: Dave Watson Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Maged Michael Cc: Michael Ellerman Cc: Paul E . McKenney Cc: Paul E. McKenney Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20171215192310.25293-1-mathieu.desnoyers@efficios.com Signed-off-by: Ingo Molnar --- kernel/sched/membarrier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c index dd79087..9bcbacb 100644 --- a/kernel/sched/membarrier.c +++ b/kernel/sched/membarrier.c @@ -89,7 +89,9 @@ static int membarrier_private_expedited(void) rcu_read_unlock(); } if (!fallback) { + preempt_disable(); smp_call_function_many(tmpmask, ipi_mb, NULL, 1); + preempt_enable(); free_cpumask_var(tmpmask); } cpus_read_unlock();