mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	jolsa@kernel.org, namhyung@kernel.org, fweisbec@gmail.com,
	tglx@linutronix.de, asharma@fb.com
Subject: [tip:perf/core] perf ui/stdio: Fix invalid percentage value of cumulated hist entries
Date: Tue, 3 Jun 2014 11:35:56 -0700	[thread overview]
Message-ID: <tip-56772ad4750e23460a4b80f7ece5377d8c922ee1@git.kernel.org> (raw)
In-Reply-To: <1401335910-16832-24-git-send-email-namhyung@kernel.org>

Commit-ID:  56772ad4750e23460a4b80f7ece5377d8c922ee1
Gitweb:     http://git.kernel.org/tip/56772ad4750e23460a4b80f7ece5377d8c922ee1
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Fri, 23 May 2014 18:31:52 +0900
Committer:  Jiri Olsa <jolsa@kernel.org>
CommitDate: Sun, 1 Jun 2014 14:35:09 +0200

perf ui/stdio: Fix invalid percentage value of cumulated hist entries

On stdio, there's a problem that it shows invalid values for
callchains in cumulated hist entries.  It's because it only cares
about the self period.  But with --children behavior, we always add
callchain info to the cumulated entries so it should use the value in
that case.

Before:

  # Children      Self  Command      Shared Object            Symbol
  # ........  ........  .......  .................  ................
  #
      61.22%     0.32%  swapper  [kernel.kallsyms]      [k] cpu_idle
                    |
                    --- cpu_idle
                       |
                       |--16530.76%-- start_secondary
                       |
                       |--2758.70%-- rest_init
                       |          start_kernel
                       |          x86_64_start_reservations
                       |          x86_64_start_kernel
                        --6837850969203030.00%-- [...]

After:

  # Children      Self  Command      Shared Object            Symbol
  # ........  ........  .......  .................  ................
  #
      61.22%     0.32%  swapper  [kernel.kallsyms]      [k] cpu_idle
                    |
                    --- cpu_idle
                       |
                       |--85.70%-- start_secondary
                       |
                        --14.30%-- rest_init
                                  start_kernel
                                  x86_64_start_reservations
                                  x86_64_start_kernel

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arun Sharma <asharma@fb.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/1401335910-16832-24-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/ui/stdio/hist.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
index 475d2f5..90122ab 100644
--- a/tools/perf/ui/stdio/hist.c
+++ b/tools/perf/ui/stdio/hist.c
@@ -271,7 +271,9 @@ static size_t hist_entry_callchain__fprintf(struct hist_entry *he,
 {
 	switch (callchain_param.mode) {
 	case CHAIN_GRAPH_REL:
-		return callchain__fprintf_graph(fp, &he->sorted_chain, he->stat.period,
+		return callchain__fprintf_graph(fp, &he->sorted_chain,
+						symbol_conf.cumulate_callchain ?
+						he->stat_acc->period : he->stat.period,
 						left_margin);
 		break;
 	case CHAIN_GRAPH_ABS:

  reply	other threads:[~2014-06-03 18:36 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  3:58 [PATCHSET 00/27] perf tools: Add support to accumulate hist periods (v11) Namhyung Kim
2014-05-29  3:58 ` [PATCH 01/27] perf tools: Introduce hists__inc_nr_samples() Namhyung Kim
2014-06-03 18:31   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 02/27] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-06-03 18:31   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 03/27] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-06-03 18:31   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 04/27] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-06-03 18:31   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 05/27] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-06-03 18:32   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 06/27] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-06-03 18:32   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 07/27] perf report: Cache cumulative callchains Namhyung Kim
2014-06-03 18:32   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 08/27] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-06-03 18:32   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 09/27] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-06-03 18:33   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 10/27] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-06-03 18:33   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 11/27] perf ui/browser: " Namhyung Kim
2014-06-03 18:33   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 12/27] perf ui/gtk: " Namhyung Kim
2014-06-03 18:33   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 13/27] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-06-03 18:33   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 14/27] perf tools: Add more hpp helper functions Namhyung Kim
2014-06-03 18:34   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 15/27] perf report: Add --children option Namhyung Kim
2014-06-03 18:34   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 16/27] perf report: Add report.children config option Namhyung Kim
2014-06-03 18:34   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 17/27] perf tools: Do not auto-remove Children column if --fields given Namhyung Kim
2014-06-03 18:34   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 18/27] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-05-29 13:16   ` Jiri Olsa
2014-05-30  4:50     ` Namhyung Kim
2014-06-03 18:34       ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 19/27] perf top: Convert " Namhyung Kim
2014-06-03 18:35   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 20/27] perf top: Add --children option Namhyung Kim
2014-06-03 18:35   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 21/27] perf top: Add top.children config option Namhyung Kim
2014-06-03 18:35   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 22/27] perf tools: Enable --children option by default Namhyung Kim
2014-06-03 18:35   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-28 19:23   ` [PATCH 22/27] " Andres Freund
2014-07-29  6:52     ` Namhyung Kim
2014-07-29 11:45       ` Andres Freund
2014-07-29 13:06         ` Arnaldo Carvalho de Melo
2014-07-29 23:29         ` Namhyung Kim
2014-05-29  3:58 ` [PATCH 23/27] perf ui/stdio: Fix invalid percentage value of cumulated hist entries Namhyung Kim
2014-06-03 18:35   ` tip-bot for Namhyung Kim [this message]
2014-05-29  3:58 ` [PATCH 24/27] perf ui/gtk: Fix callchain display Namhyung Kim
2014-06-03 18:36   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 25/27] perf tools: Reset output/sort order to default Namhyung Kim
2014-06-03 18:36   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 26/27] perf tests: Define and use symbolic names for fake symbols Namhyung Kim
2014-06-03 18:36   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29  3:58 ` [PATCH 27/27] perf tests: Add a test case for cumulating callchains Namhyung Kim
2014-06-03 18:36   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-05-29 13:59 ` [PATCHSET 00/27] perf tools: Add support to accumulate hist periods (v11) Jiri Olsa
2014-05-30  4:58   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-56772ad4750e23460a4b80f7ece5377d8c922ee1@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=asharma@fb.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome