From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
venkatesh.pallipadi@intel.com, jbarnes@virtuousgeek.org,
kjwinchester@gmail.com, suresh.b.siddha@intel.com,
airlied@redhat.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/pat] x86, PAT, PCI: Change vma prot in pci_mmap to reflect inherited prot
Date: Tue, 24 Mar 2009 09:42:29 GMT [thread overview]
Message-ID: <tip-571d1692d564e7782e55738ee87099fa038a3778@git.kernel.org> (raw)
In-Reply-To: <20090323190720.GA16831@linux-os.sc.intel.com>
Commit-ID: 571d1692d564e7782e55738ee87099fa038a3778
Gitweb: http://git.kernel.org/tip/571d1692d564e7782e55738ee87099fa038a3778
Author: Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com>
AuthorDate: Mon, 23 Mar 2009 12:07:20 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 24 Mar 2009 10:41:38 +0100
x86, PAT, PCI: Change vma prot in pci_mmap to reflect inherited prot
While looking at the issue in the thread:
http://marc.info/?l=dri-devel&m=123606627824556&w=2
noticed a bug in pci PAT code and memory type setting.
PCI mmap code did not set the proper protection in vma, when it
inherited protection in reserve_memtype. This bug only affects
the case where there exists a WC mapping before X does an mmap
with /proc or /sys pci interface. This will cause X userlevel
mmap from /proc or /sysfs to fail on fork.
Reported-by: Kevin Winchester <kjwinchester@gmail.com>
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Dave Airlie <airlied@redhat.com>
LKML-Reference: <20090323190720.GA16831@linux-os.sc.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/pci/i386.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 5ead808..f234a37 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -319,6 +319,9 @@ int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
return -EINVAL;
}
flags = new_flags;
+ vma->vm_page_prot = __pgprot(
+ (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK) |
+ flags);
}
if (((vma->vm_pgoff < max_low_pfn_mapped) ||
next prev parent reply other threads:[~2009-03-24 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 23:28 Error: freeing invalid memtype Kevin Winchester
2009-03-18 18:12 ` Pallipadi, Venkatesh
2009-03-21 23:05 ` Kevin Winchester
2009-03-23 19:07 ` Pallipadi, Venkatesh
2009-03-23 19:48 ` Ingo Molnar
2009-03-23 21:27 ` Pallipadi, Venkatesh
2009-03-24 9:42 ` Pallipadi, Venkatesh [this message]
2009-03-24 9:45 ` [tip:x86/pat] x86, PAT, PCI: Change vma prot in pci_mmap to reflect inherited prot Pallipadi, Venkatesh
2009-03-24 22:19 ` Error: freeing invalid memtype Kevin Winchester
2009-03-24 22:25 ` Ingo Molnar
2009-04-09 3:00 ` Ryan Hill
2009-04-13 18:27 ` Jason D. Clinton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-571d1692d564e7782e55738ee87099fa038a3778@git.kernel.org \
--to=venkatesh.pallipadi@intel.com \
--cc=airlied@redhat.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome