From: "tip-bot for Michael S. Tsirkin" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dbueso@suse.de, tglx@linutronix.de,
andreyknvl@google.com, hpa@zytor.com, paulmck@linux.vnet.ibm.com,
peterz@infradead.org, dave@stgolabs.net, brgerst@gmail.com,
bp@alien8.de, virtualization@lists.linux-foundation.org,
mingo@kernel.org, luto@kernel.org, torvalds@linux-foundation.org,
mst@redhat.com, akpm@linux-foundation.org, luto@amacapital.net,
bp@suse.de, dvlasenk@redhat.com
Subject: [tip:locking/core] locking/x86: Tweak the comment about use of wmb() for IO
Date: Fri, 29 Jan 2016 03:32:52 -0800 [thread overview]
Message-ID: <tip-57d9b1b43433a6ba7267c80b87d8e8f6e86edceb@git.kernel.org> (raw)
In-Reply-To: <1453921746-16178-4-git-send-email-mst@redhat.com>
Commit-ID: 57d9b1b43433a6ba7267c80b87d8e8f6e86edceb
Gitweb: http://git.kernel.org/tip/57d9b1b43433a6ba7267c80b87d8e8f6e86edceb
Author: Michael S. Tsirkin <mst@redhat.com>
AuthorDate: Thu, 28 Jan 2016 19:02:44 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 29 Jan 2016 09:40:10 +0100
locking/x86: Tweak the comment about use of wmb() for IO
On x86, we *do* still use the non-NOP rmb()/wmb() for IO barriers,
but even that is generally questionable.
Leave them around as historial unless somebody can point to a
case where they care about the performance, but tweak the
comment so people don't think they are strictly required in all
cases.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: virtualization <virtualization@lists.linux-foundation.org>
Link: http://lkml.kernel.org/r/1453921746-16178-4-git-send-email-mst@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/barrier.h b/arch/x86/include/asm/barrier.h
index a291745..bfb28ca 100644
--- a/arch/x86/include/asm/barrier.h
+++ b/arch/x86/include/asm/barrier.h
@@ -6,7 +6,7 @@
/*
* Force strict CPU ordering.
- * And yes, this is required on UP too when we're talking
+ * And yes, this might be required on UP too when we're talking
* to devices.
*/
next prev parent reply other threads:[~2016-01-29 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 17:02 [PATCH v5 0/5] x86: faster smp_mb()+documentation tweaks Michael S. Tsirkin
2016-01-28 17:02 ` [PATCH v5 1/5] x86: add cc clobber for addl Michael S. Tsirkin
2016-01-29 11:32 ` [tip:locking/core] locking/x86: Add cc clobber for ADDL tip-bot for Michael S. Tsirkin
2016-01-28 17:02 ` [PATCH v5 2/5] x86: drop a comment left over from X86_OOSTORE Michael S. Tsirkin
2016-01-29 11:32 ` [tip:locking/core] locking/x86: Drop " tip-bot for Michael S. Tsirkin
2016-01-28 17:02 ` [PATCH v5 3/5] x86: tweak the comment about use of wmb for IO Michael S. Tsirkin
2016-01-29 11:32 ` tip-bot for Michael S. Tsirkin [this message]
2016-01-28 17:02 ` [PATCH v5 4/5] x86: use mb() around clflush Michael S. Tsirkin
2016-01-28 18:25 ` Peter Zijlstra
2016-01-29 11:33 ` [tip:locking/core] locking/x86: Use mb() around clflush() tip-bot for Michael S. Tsirkin
2016-01-28 17:02 ` [PATCH v5 5/5] x86: drop mfence in favor of lock+addl Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-57d9b1b43433a6ba7267c80b87d8e8f6e86edceb@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome