mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Xiaotian Feng <dfeng@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	yinghai@kernel.org, tglx@linutronix.de, dfeng@redhat.com,
	mingo@elte.hu
Subject: [tip:x86/reboot] x86/reboot: Add pci_dev_put in reboot_fixup_32.c for consistency
Date: Thu, 3 Dec 2009 13:23:40 GMT	[thread overview]
Message-ID: <tip-57fea8f7ab67ef42b7f84999e49e47f8717a2d5b@git.kernel.org> (raw)
In-Reply-To: <1259838400-23833-1-git-send-email-dfeng@redhat.com>

Commit-ID:  57fea8f7ab67ef42b7f84999e49e47f8717a2d5b
Gitweb:     http://git.kernel.org/tip/57fea8f7ab67ef42b7f84999e49e47f8717a2d5b
Author:     Xiaotian Feng <dfeng@redhat.com>
AuthorDate: Thu, 3 Dec 2009 19:06:40 +0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 3 Dec 2009 12:17:55 +0100

x86/reboot: Add pci_dev_put in reboot_fixup_32.c for consistency

pci_get_device will increase the ref count of found device.
Although we're going to reset soon, we should use pci_dev_put
to decrease the ref count for consistency.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <1259838400-23833-1-git-send-email-dfeng@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/reboot_fixups_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot_fixups_32.c b/arch/x86/kernel/reboot_fixups_32.c
index 61a8377..201eab6 100644
--- a/arch/x86/kernel/reboot_fixups_32.c
+++ b/arch/x86/kernel/reboot_fixups_32.c
@@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
 			continue;
 
 		cur->reboot_fixup(dev);
+		pci_dev_put(dev);
 	}
 }
 

      reply	other threads:[~2009-12-03 13:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27  3:16 [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put Xiaotian Feng
2009-12-02 10:09 ` Ingo Molnar
2009-12-02 16:51   ` H. Peter Anvin
2009-12-02 17:14     ` Ingo Molnar
2009-12-03 10:07       ` Danny Feng
2009-12-03 10:40         ` Ingo Molnar
2009-12-03 11:06           ` [PATCH -tip] x86/trivial: add pci_dev_put in reboot_fixup_32.c for consistency Xiaotian Feng
2009-12-03 13:23             ` tip-bot for Xiaotian Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-57fea8f7ab67ef42b7f84999e49e47f8717a2d5b@git.kernel.org \
    --to=dfeng@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome