From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbcEXNqt (ORCPT ); Tue, 24 May 2016 09:46:49 -0400 Received: from terminus.zytor.com ([198.137.202.10]:59832 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcEXNqr (ORCPT ); Tue, 24 May 2016 09:46:47 -0400 Date: Tue, 24 May 2016 06:46:28 -0700 From: tip-bot for Matt Redfearn Message-ID: Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, matt.redfearn@imgtec.com, tglx@linutronix.de Reply-To: matt.redfearn@imgtec.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com In-Reply-To: <1464086550-24734-1-git-send-email-matt.redfearn@imgtec.com> References: <1464086550-24734-1-git-send-email-matt.redfearn@imgtec.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] genirq: Fix missing return value in irq_destroy_ipi() Git-Commit-ID: 59fa5860204ffc95128d60cba9f54f9740a42c7d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 59fa5860204ffc95128d60cba9f54f9740a42c7d Gitweb: http://git.kernel.org/tip/59fa5860204ffc95128d60cba9f54f9740a42c7d Author: Matt Redfearn AuthorDate: Tue, 24 May 2016 11:42:30 +0100 Committer: Thomas Gleixner CommitDate: Tue, 24 May 2016 15:40:14 +0200 genirq: Fix missing return value in irq_destroy_ipi() Commit 7cec18a3906b changed the return type of irq_destroy_ipi to int, but missed adding a value to one return statement. Fix this to silence the resulting compiler warning: kernel/irq/ipi.c In function ‘irq_destroy_ipi’: kernel/irq/ipi.c:128:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type] Fixes: 7cec18a3906b "genirq: Add error code reporting to irq_{reserve,destroy}_ipi" Signed-off-by: Matt Redfearn Cc: linux-mips@linux-mips.org Link: http://lkml.kernel.org/r/1464086550-24734-1-git-send-email-matt.redfearn@imgtec.com Signed-off-by: Thomas Gleixner --- kernel/irq/ipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c index c427422..89b49f6 100644 --- a/kernel/irq/ipi.c +++ b/kernel/irq/ipi.c @@ -125,7 +125,7 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest) domain = data->domain; if (WARN_ON(domain == NULL)) - return; + return -EINVAL; if (!irq_domain_is_ipi(domain)) { pr_warn("Trying to destroy a non IPI domain!\n");