From: tip-bot for Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
peterz@infradead.org, gorcunov@gmail.com, fweisbec@gmail.com,
tglx@linutronix.de, mingo@elte.hu, dzickus@redhat.com
Subject: [tip:perf/nmi] x86, watchdog: Fix build error in hw_nmi.c
Date: Thu, 13 May 2010 07:15:39 GMT [thread overview]
Message-ID: <tip-5e85391b3badd3f0e50ebdd0cafe0202a979f73a@git.kernel.org> (raw)
In-Reply-To: <1273713674-8434-1-git-send-regression-fweisbec@gmail.com>
Commit-ID: 5e85391b3badd3f0e50ebdd0cafe0202a979f73a
Gitweb: http://git.kernel.org/tip/5e85391b3badd3f0e50ebdd0cafe0202a979f73a
Author: Ingo Molnar <mingo@elte.hu>
AuthorDate: Thu, 13 May 2010 09:12:39 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 13 May 2010 09:12:39 +0200
x86, watchdog: Fix build error in hw_nmi.c
On some configs the following build error triggers:
arch/x86/kernel/apic/hw_nmi.c:35: error: 'apic' undeclared (first use in this function)
arch/x86/kernel/apic/hw_nmi.c:35: error: (Each undeclared identifier is reported only once
arch/x86/kernel/apic/hw_nmi.c:35: error: for each function it appears in.)
Because asm/apic.h was only included implicitly. Include it explicitly.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <1273713674-8434-1-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/hw_nmi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 3b40082..cefd694 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -8,6 +8,7 @@
* Bits copied from original nmi.c file
*
*/
+#include <asm/apic.h>
#include <linux/cpumask.h>
#include <linux/kdebug.h>
prev parent reply other threads:[~2010-05-13 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 1:21 [GIT PULL] Unified lockup detector Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 1/9] lockup_detector: Combine nmi_watchdog and softlockup detector Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 2/9] lockup_detector: Touch_softlockup cleanups and softlockup_tick removal Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 3/9] lockup_detector: Remove old softlockup code Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 4/9] lockup_detector: Remove nmi_watchdog.c file Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 5/9] x86: Move trigger_all_cpu_backtrace to its own die_notifier Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 6/9] x86: Cleanup hw_nmi.c cruft Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 7/9] lockup_detector: Separate touch_nmi_watchdog code path from touch_watchdog Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 8/9] lockup_detector: Make BOOTPARAM_SOFTLOCKUP_PANIC depend on LOCKUP_DETECTOR Frederic Weisbecker
2010-05-13 1:21 ` [PATCH 9/9] lockup_detector: Fix forgotten config conversion Frederic Weisbecker
2010-05-13 6:05 ` [GIT PULL] Unified lockup detector Ingo Molnar
2010-05-13 6:57 ` [tip:perf/nmi] watchdog: Export touch_softlockup_watchdog tip-bot for Ingo Molnar
2010-05-13 7:15 ` tip-bot for Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5e85391b3badd3f0e50ebdd0cafe0202a979f73a@git.kernel.org \
--to=mingo@elte.hu \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome