mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	jin.dongming@np.css.fujitsu.com, seto.hidetoshi@jp.fujitsu.com,
	kaneshige.kenji@jp.fujitsu.com, paulmck@linux.vnet.ibm.com,
	dhowells@redhat.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:core/rcu] rcu: Clean up the warning message about RCU not defined
Date: Sat, 26 Sep 2009 14:17:31 GMT	[thread overview]
Message-ID: <tip-5ef9b8e59c043624fb44e31439cecf7f8b4cd62a@git.kernel.org> (raw)
In-Reply-To: <4ABC4CAB.7090302@np.css.fujitsu.com>

Commit-ID:  5ef9b8e59c043624fb44e31439cecf7f8b4cd62a
Gitweb:     http://git.kernel.org/tip/5ef9b8e59c043624fb44e31439cecf7f8b4cd62a
Author:     Jin Dongming <jin.dongming@np.css.fujitsu.com>
AuthorDate: Fri, 25 Sep 2009 13:52:59 +0900
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 26 Sep 2009 14:33:41 +0200

rcu: Clean up the warning message about RCU not defined

When the kernel is built, there is some message printed as
following:

    include/linux/rcupdate.h:80:7: \
        warning: "CONFIG_TINY_RCU" is not defined

So I did "grep _RCU .config" to search the information of "CONFIG_TINY_RCU"
in .config file and the result is listed as following:

    Command:
        grep _RCU .config
    Result:
        CONFIG_TREE_RCU=y
        # CONFIG_TREE_PREEMPT_RCU is not set
        # CONFIG_TINY_RCU is not set
        CONFIG_RCU_TRACE=y
        CONFIG_RCU_FANOUT=64
        # CONFIG_RCU_FANOUT_EXACT is not set
        CONFIG_TREE_RCU_TRACE=y
        # CONFIG_RCU_TORTURE_TEST is not set
        # CONFIG_RCU_CPU_STALL_DETECTOR is not set

Though the "WARNING" does not give impact to build kernel, I think
it should be cleaned up. And I made the patch for modifying it.
With this patch there is not any other warning message of
CONFIG_TINY_RCU and the kernel could be built successfully. And I
confirmed that the built kernel works well.

Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: "Paul E. McKenney " <paulmck@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org
Cc: David Howells <dhowells@redhat.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
LKML-Reference: <4ABC4CAB.7090302@np.css.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 include/linux/rcupdate.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index b2f1e10..fe5c560 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -77,7 +77,7 @@ extern int rcu_scheduler_active;
 
 #if defined(CONFIG_TREE_RCU) || defined(CONFIG_TREE_PREEMPT_RCU)
 #include <linux/rcutree.h>
-#elif CONFIG_TINY_RCU
+#elif defined(CONFIG_TINY_RCU)
 #include <linux/rcutiny.h>
 #else
 #error "Unknown RCU implementation specified to kernel configuration"

      parent reply	other threads:[~2009-09-26 14:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25  4:52 [Patch x86-tip] " Jin Dongming
2009-09-25  6:15 ` Paul E. McKenney
2009-09-25  9:39 ` David Howells
2009-09-26 14:17 ` tip-bot for Jin Dongming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-5ef9b8e59c043624fb44e31439cecf7f8b4cd62a@git.kernel.org \
    --to=jin.dongming@np.css.fujitsu.com \
    --cc=dhowells@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome