From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbdGZRUG (ORCPT ); Wed, 26 Jul 2017 13:20:06 -0400 Received: from terminus.zytor.com ([65.50.211.136]:38555 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbdGZRUE (ORCPT ); Wed, 26 Jul 2017 13:20:04 -0400 Date: Wed, 26 Jul 2017 10:17:50 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: namhyung@kernel.org, tglx@linutronix.de, dsahern@gmail.com, adrian.hunter@intel.com, hpa@zytor.com, acme@redhat.com, jolsa@kernel.org, wangnan0@huawei.com, mingo@kernel.org, linux-kernel@vger.kernel.org Reply-To: namhyung@kernel.org, tglx@linutronix.de, adrian.hunter@intel.com, dsahern@gmail.com, hpa@zytor.com, acme@redhat.com, jolsa@kernel.org, wangnan0@huawei.com, mingo@kernel.org, linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf trace: Introduce filter_loop_pids() Git-Commit-ID: dd1a50377c92321f78fa4d0601bb4d88d88670ab X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: dd1a50377c92321f78fa4d0601bb4d88d88670ab Gitweb: http://git.kernel.org/tip/dd1a50377c92321f78fa4d0601bb4d88d88670ab Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 20 Jul 2017 11:17:51 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 20 Jul 2017 11:17:51 -0300 perf trace: Introduce filter_loop_pids() No change in functionality, just to make clearer that what we want when filtering the tracer pid in a system wide tracing session is to avoid a feedback loop. This also paves the way for a more interesting loop avoidance algorithm, one that tries to figure out if we are in a ssh session, xterm, etc. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-5fcttc5kdjkcyp9404ezkuy9@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 9e74e67..0ba36f0 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2239,6 +2239,16 @@ out_enomem: goto out; } +static int trace__set_filter_loop_pids(struct trace *trace) +{ + int nr = 1; + pid_t pids[32] = { + getpid(), + }; + + return perf_evlist__set_filter_pids(trace->evlist, nr, pids); +} + static int trace__run(struct trace *trace, int argc, const char **argv) { struct perf_evlist *evlist = trace->evlist; @@ -2362,7 +2372,7 @@ static int trace__run(struct trace *trace, int argc, const char **argv) if (trace->filter_pids.nr > 0) err = perf_evlist__set_filter_pids(evlist, trace->filter_pids.nr, trace->filter_pids.entries); else if (thread_map__pid(evlist->threads, 0) == -1) - err = perf_evlist__set_filter_pid(evlist, getpid()); + err = trace__set_filter_loop_pids(trace); if (err < 0) goto out_error_mem;