mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Seiji Aguchi <seiji.aguchi@hds.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, satoru.moriya@hds.com,
	hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
	seiji.aguchi@hds.com, tony.luck@intel.com,
	dle-develop@lists.sourceforge.net, tglx@linutronix.de,
	dzickus@redhat.com
Subject: [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()
Date: Fri, 18 May 2012 05:11:19 -0700	[thread overview]
Message-ID: <tip-62be73eafaa045d3233337303fb140f7f8a61135@git.kernel.org> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com>

Commit-ID:  62be73eafaa045d3233337303fb140f7f8a61135
Gitweb:     http://git.kernel.org/tip/62be73eafaa045d3233337303fb140f7f8a61135
Author:     Seiji Aguchi <seiji.aguchi@hds.com>
AuthorDate: Tue, 15 May 2012 17:35:09 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 18 May 2012 14:02:10 +0200

kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()

This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(),
to serialize the crash-logging process via smp_send_stop() and to
thus retrieve a more stable crash image of all CPUs stopped.

Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: dle-develop@lists.sourceforge.net <dle-develop@lists.sourceforge.net>
Cc: Satoru Moriya <satoru.moriya@hds.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: a.p.zijlstra@chello.nl <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/panic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index b6215b7..d2a5f4e 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -108,8 +108,6 @@ void panic(const char *fmt, ...)
 	 */
 	crash_kexec(NULL);
 
-	kmsg_dump(KMSG_DUMP_PANIC);
-
 	/*
 	 * Note smp_send_stop is the usual smp shutdown function, which
 	 * unfortunately means it may not be hardened to work in a panic
@@ -117,6 +115,8 @@ void panic(const char *fmt, ...)
 	 */
 	smp_send_stop();
 
+	kmsg_dump(KMSG_DUMP_PANIC);
+
 	atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
 
 	bust_spinlocks(0);

      parent reply	other threads:[~2012-05-18 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 21:35 [PATCH -tip] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() Seiji Aguchi
2012-05-18 10:49 ` [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() tip-bot for Seiji Aguchi
2012-05-18 11:26   ` Peter Zijlstra
2012-05-18 12:03     ` Ingo Molnar
2012-05-18 12:11 ` tip-bot for Seiji Aguchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-62be73eafaa045d3233337303fb140f7f8a61135@git.kernel.org \
    --to=seiji.aguchi@hds.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=dzickus@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=satoru.moriya@hds.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome