From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
mingo@kernel.org, a.p.zijlstra@chello.nl, peterz@infradead.org,
acme@ghostprotocols.net, jolsa@redhat.com,
vincent.weaver@maine.edu, rostedt@goodmis.org,
tglx@linutronix.de
Subject: [tip:perf/core] perf: Disallow user-space stack dumps for function trace events
Date: Tue, 11 Mar 2014 05:38:31 -0700 [thread overview]
Message-ID: <tip-63c45f4ba533e9749da16298db53e491c25d805b@git.kernel.org> (raw)
In-Reply-To: <1393775800-13524-3-git-send-email-jolsa@redhat.com>
Commit-ID: 63c45f4ba533e9749da16298db53e491c25d805b
Gitweb: http://git.kernel.org/tip/63c45f4ba533e9749da16298db53e491c25d805b
Author: Jiri Olsa <jolsa@redhat.com>
AuthorDate: Sun, 2 Mar 2014 16:56:39 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 11 Mar 2014 11:57:58 +0100
perf: Disallow user-space stack dumps for function trace events
Recent issues with user space callchains processing within
page fault handler tracing showed as Peter said 'there's
just too much fail surface'.
The user space stack dump is just another source of the this issue.
Related list discussions:
http://marc.info/?t=139302086500001&r=1&w=2
http://marc.info/?t=139301437300003&r=1&w=2
Suggested-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1393775800-13524-3-git-send-email-jolsa@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/trace/trace_event_perf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
index d5e01c3..c894614 100644
--- a/kernel/trace/trace_event_perf.c
+++ b/kernel/trace/trace_event_perf.c
@@ -42,6 +42,13 @@ static int perf_trace_event_perm(struct ftrace_event_call *tp_event,
*/
if (!p_event->attr.exclude_callchain_user)
return -EINVAL;
+
+ /*
+ * Same reason to disable user stack dump as for user space
+ * callchains above.
+ */
+ if (p_event->attr.sample_type & PERF_SAMPLE_STACK_USER)
+ return -EINVAL;
}
/* No tracing, just counting, so no obvious leak */
next prev parent reply other threads:[~2014-03-11 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 15:56 [PATCH 0/3] perf: Disable user space dumps for function trace event Jiri Olsa
2014-03-02 15:56 ` [PATCH 1/3] perf: Disallow user space callchains " Jiri Olsa
2014-03-11 12:38 ` [tip:perf/core] perf: Disallow user-space callchains for function trace events tip-bot for Jiri Olsa
2014-03-02 15:56 ` [PATCH 2/3] perf: Disallow user space stack dump for function trace event Jiri Olsa
2014-03-02 16:59 ` Steven Rostedt
2014-03-11 12:38 ` tip-bot for Jiri Olsa [this message]
2014-03-02 15:56 ` [PATCH 3/3] perf tools: Disable user space callchain/stack " Jiri Olsa
2014-03-11 12:38 ` [tip:perf/core] perf tools: Disable user-space callchain/ stack dumps for function trace events tip-bot for Jiri Olsa
2014-03-02 16:42 ` [PATCH 0/3] perf: Disable user space dumps for function trace event Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-63c45f4ba533e9749da16298db53e491c25d805b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome