From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbbL2KrD (ORCPT ); Tue, 29 Dec 2015 05:47:03 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57064 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753272AbbL2KrA (ORCPT ); Tue, 29 Dec 2015 05:47:00 -0500 Date: Tue, 29 Dec 2015 02:46:44 -0800 From: tip-bot for Andrea Merello Message-ID: Cc: marc.zyngier@arm.com, eric@anholt.net, jason@lakedaemon.net, f.fainelli@gmail.com, tglx@linutronix.de, swarren@wwwdotorg.org, andrea.merello@gmail.com, mingo@kernel.org, hpa@zytor.com, lee@kernel.org, linux-kernel@vger.kernel.org Reply-To: andrea.merello@gmail.com, mingo@kernel.org, hpa@zytor.com, lee@kernel.org, linux-kernel@vger.kernel.org, marc.zyngier@arm.com, eric@anholt.net, jason@lakedaemon.net, f.fainelli@gmail.com, swarren@wwwdotorg.org, tglx@linutronix.de In-Reply-To: <1451166444-11044-5-git-send-email-eric@anholt.net> References: <1451166444-11044-5-git-send-email-eric@anholt.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] irqchip/bcm2836: Make code more readable Git-Commit-ID: 64103f061573e3d7670ba295b07919fb8fc7594c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 64103f061573e3d7670ba295b07919fb8fc7594c Gitweb: http://git.kernel.org/tip/64103f061573e3d7670ba295b07919fb8fc7594c Author: Andrea Merello AuthorDate: Sat, 26 Dec 2015 13:47:24 -0800 Committer: Thomas Gleixner CommitDate: Tue, 29 Dec 2015 11:40:46 +0100 irqchip/bcm2836: Make code more readable Avoid using hardcoded magics. We have a #define for this number. No functional changes. Signed-off-by: Andrea Merello Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt Cc: linux-arm-kernel@lists.infradead.org Cc: Stephen Warren Cc: Lee Jones Cc: Florian Fainelli Cc: Jason Cooper Cc: Marc Zyngier Cc: linux-rpi-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1451166444-11044-5-git-send-email-eric@anholt.net Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index bb8f234..963065a 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -167,7 +167,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs) u32 stat; stat = readl_relaxed(intc.base + LOCAL_IRQ_PENDING0 + 4 * cpu); - if (stat & 0x10) { + if (stat & BIT(LOCAL_IRQ_MAILBOX0)) { #ifdef CONFIG_SMP void __iomem *mailbox0 = (intc.base + LOCAL_MAILBOX0_CLR0 + 16 * cpu);