From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbbKXJex (ORCPT ); Tue, 24 Nov 2015 04:34:53 -0500 Received: from terminus.zytor.com ([198.137.202.10]:55357 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753866AbbKXJet (ORCPT ); Tue, 24 Nov 2015 04:34:49 -0500 Date: Tue, 24 Nov 2015 01:33:52 -0800 From: tip-bot for Borislav Petkov Message-ID: Cc: linux-kernel@vger.kernel.org, brgerst@gmail.com, torvalds@linux-foundation.org, luto@amacapital.net, dvlasenk@redhat.com, peterz@infradead.org, hpa@zytor.com, mingo@kernel.org, bp@alien8.de, tglx@linutronix.de, bp@suse.de, luto@kernel.org Reply-To: brgerst@gmail.com, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, dvlasenk@redhat.com, luto@amacapital.net, torvalds@linux-foundation.org, tglx@linutronix.de, bp@alien8.de, mingo@kernel.org, luto@kernel.org, bp@suse.de In-Reply-To: <1448273546-2567-7-git-send-email-bp@alien8.de> References: <1448273546-2567-7-git-send-email-bp@alien8.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/cpu] x86/MSR: Chop off lower 32-bit value Git-Commit-ID: 679bcea857d72868e3431dde3a0e158bf0ed9119 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 679bcea857d72868e3431dde3a0e158bf0ed9119 Gitweb: http://git.kernel.org/tip/679bcea857d72868e3431dde3a0e158bf0ed9119 Author: Borislav Petkov AuthorDate: Mon, 23 Nov 2015 11:12:26 +0100 Committer: Ingo Molnar CommitDate: Tue, 24 Nov 2015 09:15:55 +0100 x86/MSR: Chop off lower 32-bit value sparse complains that the cast truncates the high bits. But here we really do know what we're doing and we need the lower 32 bits only as the @low argument. So make that explicit. Suggested-by: Andy Lutomirski Signed-off-by: Borislav Petkov Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1448273546-2567-7-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar --- arch/x86/include/asm/msr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h index 77d8b28..8613382 100644 --- a/arch/x86/include/asm/msr.h +++ b/arch/x86/include/asm/msr.h @@ -190,7 +190,7 @@ static inline void wrmsr(unsigned msr, unsigned low, unsigned high) static inline void wrmsrl(unsigned msr, u64 val) { - native_write_msr(msr, (u32)val, (u32)(val >> 32)); + native_write_msr(msr, (u32)(val & 0xffffffffULL), (u32)(val >> 32)); } /* wrmsr with exception handling */