From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbdJRQ1Z (ORCPT ); Wed, 18 Oct 2017 12:27:25 -0400 Received: from terminus.zytor.com ([65.50.211.136]:42959 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbdJRQ1X (ORCPT ); Wed, 18 Oct 2017 12:27:23 -0400 Date: Wed, 18 Oct 2017 09:23:03 -0700 From: tip-bot for Kamalesh Babulal Message-ID: Cc: peterz@infradead.org, hpa@zytor.com, kamalesh@linux.vnet.ibm.com, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, jpoimboe@redhat.com, torvalds@linux-foundation.org Reply-To: kamalesh@linux.vnet.ibm.com, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, jpoimboe@redhat.com, torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com In-Reply-To: <1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com> References: <1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/objtool] objtool: Print top level commands on incorrect usage Git-Commit-ID: 6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e Gitweb: https://git.kernel.org/tip/6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e Author: Kamalesh Babulal AuthorDate: Sat, 14 Oct 2017 20:17:54 +0530 Committer: Ingo Molnar CommitDate: Wed, 18 Oct 2017 15:22:26 +0200 objtool: Print top level commands on incorrect usage Print top-level objtool commands, along with the error on incorrect command line usage. Objtool command line parser exit's with code 129, for incorrect usage. Convert the cmd_usage() exit code also, to maintain consistency across objtool. After the patch: $ ./objtool -j Unknown option: -j usage: objtool COMMAND [ARGS] Commands: check Perform stack metadata validation on an object file orc Generate in-place ORC unwind tables for an object file $ echo $? 129 Signed-off-by: Kamalesh Babulal Acked-by: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com Signed-off-by: Ingo Molnar --- tools/objtool/objtool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c index 31e0f91..07f3299 100644 --- a/tools/objtool/objtool.c +++ b/tools/objtool/objtool.c @@ -70,7 +70,7 @@ static void cmd_usage(void) printf("\n"); - exit(1); + exit(129); } static void handle_options(int *argc, const char ***argv) @@ -86,9 +86,7 @@ static void handle_options(int *argc, const char ***argv) break; } else { fprintf(stderr, "Unknown option: %s\n", cmd); - fprintf(stderr, "\n Usage: %s\n", - objtool_usage_string); - exit(1); + cmd_usage(); } (*argv)++;