From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754683AbbCCGYy (ORCPT ); Tue, 3 Mar 2015 01:24:54 -0500 Received: from terminus.zytor.com ([198.137.202.10]:49273 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbbCCGYw (ORCPT ); Tue, 3 Mar 2015 01:24:52 -0500 Date: Mon, 2 Mar 2015 22:24:21 -0800 From: tip-bot for Ingo Molnar Message-ID: Cc: jolsa@redhat.com, tglx@linutronix.de, david.ahern@oracle.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, peterz@infradead.org, mingo@kernel.org, acme@redhat.com, hpa@zytor.com Reply-To: tglx@linutronix.de, david.ahern@oracle.com, linux-kernel@vger.kernel.org, jolsa@redhat.com, hpa@zytor.com, acme@redhat.com, namhyung@kernel.org, peterz@infradead.org, mingo@kernel.org In-Reply-To: <20150228083345.GB31887@gmail.com> References: <20150228083345.GB31887@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Improve Python feature detection messages Git-Commit-ID: 6c5aa23704e2786eb1a2a733165eef95c4375f41 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 6c5aa23704e2786eb1a2a733165eef95c4375f41 Gitweb: http://git.kernel.org/tip/6c5aa23704e2786eb1a2a733165eef95c4375f41 Author: Ingo Molnar AuthorDate: Sat, 28 Feb 2015 09:33:45 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 2 Mar 2015 12:13:51 -0300 perf tools: Improve Python feature detection messages Change the Python detection message from: config/Makefile:566: No python-config tool was found config/Makefile:566: Python support will not be built config/Makefile:565: No 'python-config' tool was found: disables Python support - please install python-devel/python-dev It's now a standard one-line message with a package install suggestion, and it also uses the standard language used by other feature detection messages. Signed-off-by: Ingo Molnar Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20150228083345.GB31887@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/config/Makefile | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index c3570b5..d3efeef 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -548,22 +548,21 @@ endif disable-python = $(eval $(disable-python_code)) define disable-python_code CFLAGS += -DNO_LIBPYTHON - $(if $(1),$(warning No $(1) was found)) - $(warning Python support will not be built) + $(warning $1) NO_LIBPYTHON := 1 endef ifdef NO_LIBPYTHON - $(call disable-python) + $(call disable-python,Python support disabled by user) else ifndef PYTHON - $(call disable-python,python interpreter) + $(call disable-python,No python interpreter was found: disables Python support - please install python-devel/python-dev) else PYTHON_WORD := $(call shell-wordify,$(PYTHON)) ifndef PYTHON_CONFIG - $(call disable-python,python-config tool) + $(call disable-python,No 'python-config' tool was found: disables Python support - please install python-devel/python-dev) else PYTHON_CONFIG_SQ := $(call shell-sq,$(PYTHON_CONFIG)) @@ -575,7 +574,7 @@ else FLAGS_PYTHON_EMBED := $(PYTHON_EMBED_CCOPTS) $(PYTHON_EMBED_LDOPTS) ifneq ($(feature-libpython), 1) - $(call disable-python,Python.h (for Python 2.x)) + $(call disable-python,No 'Python.h' (for Python 2.x support) was found: disables Python support - please install python-devel/python-dev) else ifneq ($(feature-libpython-version), 1)