From: tip-bot for Andreea-Cristina Bernat <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, acme@kernel.org, tglx@linutronix.de,
bernat.ada@gmail.com
Subject: [tip:perf/core] perf/core: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Date: Tue, 9 Sep 2014 07:53:08 -0700 [thread overview]
Message-ID: <tip-70691d4a0bf7c871559d4ef1b0056edefbca123b@git.kernel.org> (raw)
In-Reply-To: <20140822132605.GA20130@ada>
Commit-ID: 70691d4a0bf7c871559d4ef1b0056edefbca123b
Gitweb: http://git.kernel.org/tip/70691d4a0bf7c871559d4ef1b0056edefbca123b
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com>
AuthorDate: Fri, 22 Aug 2014 16:26:05 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 9 Sep 2014 06:53:05 +0200
perf/core: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Link: http://lkml.kernel.org/r/20140822132605.GA20130@ada
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 01bd42e..f917dec 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5908,7 +5908,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash)
if (!hlist)
return;
- rcu_assign_pointer(swhash->swevent_hlist, NULL);
+ RCU_INIT_POINTER(swhash->swevent_hlist, NULL);
kfree_rcu(hlist, rcu_head);
}
prev parent reply other threads:[~2014-09-09 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 13:26 [PATCH] kernel: events: core: " Andreea-Cristina Bernat
2014-09-09 9:42 ` Peter Zijlstra
2014-09-09 16:16 ` Paul E. McKenney
2014-09-10 13:12 ` Peter Zijlstra
2014-09-12 16:30 ` Paul E. McKenney
2014-09-26 14:53 ` Peter Zijlstra
2014-09-28 7:36 ` Paul E. McKenney
2014-09-09 14:53 ` tip-bot for Andreea-Cristina Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-70691d4a0bf7c871559d4ef1b0056edefbca123b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@kernel.org \
--cc=bernat.ada@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome