From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbbCWMZr (ORCPT ); Mon, 23 Mar 2015 08:25:47 -0400 Received: from terminus.zytor.com ([198.137.202.10]:41453 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbbCWMZn (ORCPT ); Mon, 23 Mar 2015 08:25:43 -0400 Date: Mon, 23 Mar 2015 05:25:12 -0700 From: tip-bot for Steven Rostedt Message-ID: Cc: akpm@linux-foundation.org, hpa@zytor.com, peterz@infradead.org, rostedt@goodmis.org, fweisbec@gmail.com, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Reply-To: fweisbec@gmail.com, rostedt@goodmis.org, hpa@zytor.com, peterz@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org In-Reply-To: <20150319101851.4d224d9b@gandalf.local.home> References: <20150319101851.4d224d9b@gandalf.local.home> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] irq_work: Fix build failure when CONFIG_IRQ_WORK is not defined Git-Commit-ID: 71ad00d61ec861dc68b4544887729850e58cb99b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 71ad00d61ec861dc68b4544887729850e58cb99b Gitweb: http://git.kernel.org/tip/71ad00d61ec861dc68b4544887729850e58cb99b Author: Steven Rostedt AuthorDate: Thu, 19 Mar 2015 10:18:51 -0400 Committer: Ingo Molnar CommitDate: Mon, 23 Mar 2015 10:55:21 +0100 irq_work: Fix build failure when CONFIG_IRQ_WORK is not defined When CONFIG_IRQ_WORK is not defined (difficult to do, as it also requires CONFIG_PRINTK not to be defined), we get a build failure: kernel/built-in.o: In function `flush_smp_call_function_queue': kernel/smp.c:263: undefined reference to `irq_work_run' kernel/smp.c:263: undefined reference to `irq_work_run' Makefile:933: recipe for target 'vmlinux' failed Simplest thing to do is to make irq_work_run() a nop when not set. Signed-off-by: Steven Rostedt Signed-off-by: Peter Zijlstra (Intel) Cc: Andrew Morton Cc: Frederic Weisbecker Link: http://lkml.kernel.org/r/20150319101851.4d224d9b@gandalf.local.home Signed-off-by: Ingo Molnar --- include/linux/irq_work.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h index bf3fe71..47b9ebd 100644 --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -38,16 +38,17 @@ bool irq_work_queue(struct irq_work *work); bool irq_work_queue_on(struct irq_work *work, int cpu); #endif -void irq_work_run(void); void irq_work_tick(void); void irq_work_sync(struct irq_work *work); #ifdef CONFIG_IRQ_WORK #include +void irq_work_run(void); bool irq_work_needs_cpu(void); #else static inline bool irq_work_needs_cpu(void) { return false; } +static inline void irq_work_run(void) { } #endif #endif /* _LINUX_IRQ_WORK_H */