From: tip-bot for Namhyung Kim <namhyung@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
torvalds@linux-foundation.org, namhyung@gmail.com,
fweisbec@gmail.com, rostedt@goodmis.org,
akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:core/urgent] x86, dumpstack: Use %pB format specifier for stack trace
Date: Thu, 24 Mar 2011 07:58:17 GMT [thread overview]
Message-ID: <tip-71f9e59800e5ad4e6b683348424c9fe54306cd43@git.kernel.org> (raw)
In-Reply-To: <1300934550-21394-2-git-send-email-namhyung@gmail.com>
Commit-ID: 71f9e59800e5ad4e6b683348424c9fe54306cd43
Gitweb: http://git.kernel.org/tip/71f9e59800e5ad4e6b683348424c9fe54306cd43
Author: Namhyung Kim <namhyung@gmail.com>
AuthorDate: Thu, 24 Mar 2011 11:42:30 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 24 Mar 2011 08:36:10 +0100
x86, dumpstack: Use %pB format specifier for stack trace
Improve noreturn function entries in call traces:
Before:
Call Trace:
[<ffffffff812a8502>] panic+0x8c/0x18d
[<ffffffffa000012a>] deep01+0x0/0x38 [test_panic] <--- bad
[<ffffffff81104666>] proc_file_write+0x73/0x8d
[<ffffffff811000b3>] proc_reg_write+0x8d/0xac
[<ffffffff810c7d32>] vfs_write+0xa1/0xc5
[<ffffffff810c7e0f>] sys_write+0x45/0x6c
[<ffffffff8f02943b>] system_call_fastpath+0x16/0x1b
After:
Call Trace:
[<ffffffff812bce69>] panic+0x8c/0x18d
[<ffffffffa000012a>] panic_write+0x20/0x20 [test_panic] <--- good
[<ffffffff81115fab>] proc_file_write+0x73/0x8d
[<ffffffff81111a5f>] proc_reg_write+0x8d/0xac
[<ffffffff810d90ee>] vfs_write+0xa1/0xc5
[<ffffffff810d91cb>] sys_write+0x45/0x6c
[<ffffffff812c07fb>] system_call_fastpath+0x16/0x1b
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1300934550-21394-2-git-send-email-namhyung@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/dumpstack.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 999e279..24d0479 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -27,7 +27,7 @@ static int die_counter;
void printk_address(unsigned long address, int reliable)
{
- printk(" [<%p>] %s%pS\n", (void *) address,
+ printk(" [<%p>] %s%pB\n", (void *) address,
reliable ? "" : "? ", (void *) address);
}
next prev parent reply other threads:[~2011-03-24 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 2:42 [PATCH v2 1/2] vsprintf: introduce %pB format specifier Namhyung Kim
2011-03-24 2:42 ` [PATCH v2 2/2] x86, dumpstack: use %pB format specifier for stack trace Namhyung Kim
2011-03-24 7:58 ` tip-bot for Namhyung Kim [this message]
2011-03-24 7:57 ` [tip:core/urgent] vsprintf: Introduce %pB format specifier tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-71f9e59800e5ad4e6b683348424c9fe54306cd43@git.kernel.org \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome