mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Ard Biesheuvel <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: matt@codeblueprint.co.uk, mka@chromium.org,
	ard.biesheuvel@linaro.org, torvalds@linux-foundation.org,
	hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de,
	peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: [tip:efi/core] efi/libstub/arm64: Use hidden attribute for struct screen_info reference
Date: Mon, 21 Aug 2017 02:15:58 -0700	[thread overview]
Message-ID: <tip-760b61d76da6d6a99eb245ab61abf71ca5415cea@git.kernel.org> (raw)
In-Reply-To: <20170818194947.19347-3-ard.biesheuvel@linaro.org>

Commit-ID:  760b61d76da6d6a99eb245ab61abf71ca5415cea
Gitweb:     http://git.kernel.org/tip/760b61d76da6d6a99eb245ab61abf71ca5415cea
Author:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
AuthorDate: Fri, 18 Aug 2017 20:49:35 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 21 Aug 2017 09:43:49 +0200

efi/libstub/arm64: Use hidden attribute for struct screen_info reference

To prevent the compiler from emitting absolute references to screen_info
when building position independent code, redeclare the symbol with hidden
visibility.

Tested-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170818194947.19347-3-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/arm64/include/asm/efi.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h
index 8f3043a..464ac85 100644
--- a/arch/arm64/include/asm/efi.h
+++ b/arch/arm64/include/asm/efi.h
@@ -81,6 +81,9 @@ static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base,
 #define alloc_screen_info(x...)		&screen_info
 #define free_screen_info(x...)
 
+/* redeclare as 'hidden' so the compiler will generate relative references */
+extern struct screen_info screen_info __attribute__((__visibility__("hidden")));
+
 static inline void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
 {
 }

  reply	other threads:[~2017-08-21  9:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 19:49 [GIT PULL 00/14] EFI changes for v4.14 Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 01/14] efi: arm: Don't mark ACPI reclaim memory as MEMBLOCK_NOMAP Ard Biesheuvel
2017-08-21  9:15   ` [tip:efi/core] efi/arm: " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 02/14] efi/libstub: arm64: use hidden attribute for struct screen_info reference Ard Biesheuvel
2017-08-21  9:15   ` tip-bot for Ard Biesheuvel [this message]
2017-08-18 19:49 ` [PATCH 03/14] efi/libstub: arm64: force 'hidden' visibility for section markers Ard Biesheuvel
2017-08-21  9:16   ` [tip:efi/core] efi/libstub/arm64: Force " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 04/14] efi/libstub: arm64: set -fpie when building the EFI stub Ard Biesheuvel
2017-08-21  9:16   ` [tip:efi/core] efi/libstub/arm64: Set " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 05/14] efi: arm/arm64: Add missing assignment of efi.config_table Ard Biesheuvel
2017-08-21  9:17   ` [tip:efi/core] efi/arm/arm64: " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 06/14] efi/reboot: Fall back to original power-off method if EFI_RESET_SHUTDOWN returns Ard Biesheuvel
2017-08-21  9:17   ` [tip:efi/core] " tip-bot for Hans de Goede
2017-08-18 19:49 ` [PATCH 07/14] drivers/fbdev: efifb: allow BAR to be moved instead of claiming it Ard Biesheuvel
2017-08-21  9:17   ` [tip:efi/core] drivers/fbdev/efifb: Allow " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 08/14] arm: efi: remove forbidden values from the PE/COFF header Ard Biesheuvel
2017-08-21  9:18   ` [tip:efi/core] arm/efi: Remove " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 09/14] arm: efi: remove pointless dummy .reloc section Ard Biesheuvel
2017-08-21  9:18   ` [tip:efi/core] arm/efi: Remove " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 10/14] arm: efi: replace open coded constants with symbolic ones Ard Biesheuvel
2017-08-21  9:19   ` [tip:efi/core] arm/efi: Replace " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 11/14] arm: efi: split zImage code and data into separate PE/COFF sections Ard Biesheuvel
2017-08-21  9:19   ` [tip:efi/core] arm/efi: Split " tip-bot for Ard Biesheuvel
2017-08-18 19:49 ` [PATCH 12/14] firmware: dcdbas: constify attribute_group structures Ard Biesheuvel
2017-08-21  9:19   ` [tip:efi/core] firmware/dcdbas: Constify " tip-bot for Arvind Yadav
2017-08-18 19:49 ` [PATCH 13/14] firmware: efi: constify " Ard Biesheuvel
2017-08-21  9:20   ` [tip:efi/core] firmware/efi: Constify " tip-bot for Arvind Yadav
2017-08-18 19:49 ` [PATCH 14/14] firmware: efi: esrt: constify " Ard Biesheuvel
2017-08-21  9:20   ` [tip:efi/core] firmware/efi/esrt: Constify " tip-bot for Arvind Yadav
2017-08-21  9:34 ` [GIT PULL 00/14] EFI changes for v4.14 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-760b61d76da6d6a99eb245ab61abf71ca5415cea@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=mka@chromium.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®