From: tip-bot for Heinrich Schuchardt <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hpa@zytor.com, riel@surriel.com,
peterz@infradead.org, cai@gmx.us, torvalds@linux-foundation.org,
mingo@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com,
ard.biesheuvel@linaro.org, xypron.glpk@gmx.de,
linux-kernel@vger.kernel.org, luto@kernel.org
Subject: [tip:efi/urgent] efi: Align 'efi_guid_t' to 64 bits
Date: Mon, 17 Dec 2018 10:16:27 -0800 [thread overview]
Message-ID: <tip-793423cf07e51e3185b8680167115813589c057d@git.kernel.org> (raw)
In-Reply-To: <20181217180214.9436-3-ard.biesheuvel@linaro.org>
Commit-ID: 793423cf07e51e3185b8680167115813589c057d
Gitweb: https://git.kernel.org/tip/793423cf07e51e3185b8680167115813589c057d
Author: Heinrich Schuchardt <xypron.glpk@gmx.de>
AuthorDate: Mon, 17 Dec 2018 19:02:14 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 17 Dec 2018 19:12:48 +0100
efi: Align 'efi_guid_t' to 64 bits
The UEFI Specification Version 2.7 Errata A defines:
"EFI_GUID
128-bit buffer containing a unique identifier value.
Unless otherwise specified, aligned on a 64-bit boundary."
Before this patch efi_guid_t was only 8-bit aligned.
Note that this could potentially trigger alignment faults during
EFI runtime services calls on 32-bit ARM, given that it does not
permit load/store double or load/store multiple instructions to
operate on memory addresses that are not 32-bit aligned.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: <stable@vger.kernel.org> # v4.9+, or earlier if possible
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qian Cai <cai@gmx.us>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20181217180214.9436-3-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/efi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 100ce4a4aff6..e6480c805932 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -48,7 +48,7 @@ typedef u16 efi_char16_t; /* UNICODE character */
typedef u64 efi_physical_addr_t;
typedef void *efi_handle_t;
-typedef guid_t efi_guid_t;
+typedef guid_t efi_guid_t __aligned(8);
#define EFI_GUID(a,b,c,d0,d1,d2,d3,d4,d5,d6,d7) \
GUID_INIT(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)
next prev parent reply other threads:[~2018-12-17 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 18:02 [GIT PULL 0/2] Final EFI fixes for v4.20 Ard Biesheuvel
2018-12-17 18:02 ` [PATCH 1/2] efi: let kmemleak ignore false positives Ard Biesheuvel
2018-12-17 18:15 ` [tip:efi/urgent] efi: Let " tip-bot for Qian Cai
2018-12-17 18:02 ` [PATCH 2/2] efi: efi_guid_t must be 64-bit aligned Ard Biesheuvel
2018-12-17 18:16 ` tip-bot for Heinrich Schuchardt [this message]
2018-12-17 22:33 ` [tip:efi/urgent] efi: Align 'efi_guid_t' to 64 bits Heinrich Schuchardt
2018-12-17 22:42 ` Ard Biesheuvel
2018-12-17 23:20 ` Heinrich Schuchardt
2018-12-19 22:50 ` Ard Biesheuvel
2018-12-21 0:08 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-793423cf07e51e3185b8680167115813589c057d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=cai@gmx.us \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome