From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616AbbHFHBZ (ORCPT ); Thu, 6 Aug 2015 03:01:25 -0400 Received: from terminus.zytor.com ([198.137.202.10]:55883 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978AbbHFHBX (ORCPT ); Thu, 6 Aug 2015 03:01:23 -0400 Date: Thu, 6 Aug 2015 00:01:00 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: eranian@google.com, acme@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, bp@suse.de, adrian.hunter@intel.com, namhyung@kernel.org, tglx@linutronix.de, hpa@zytor.com, jolsa@redhat.com, dsahern@gmail.com, fweisbec@gmail.com, mail@milianw.de Reply-To: linux-kernel@vger.kernel.org, acme@redhat.com, eranian@google.com, mingo@kernel.org, jolsa@redhat.com, tglx@linutronix.de, hpa@zytor.com, fweisbec@gmail.com, mail@milianw.de, dsahern@gmail.com, namhyung@kernel.org, adrian.hunter@intel.com, bp@suse.de To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf trace: Do not show syscall tracepoint filter in the --no-syscalls case Git-Commit-ID: 2e5e5f876143b147b98d0c0854b5fc577412b05b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 2e5e5f876143b147b98d0c0854b5fc577412b05b Gitweb: http://git.kernel.org/tip/2e5e5f876143b147b98d0c0854b5fc577412b05b Author: Arnaldo Carvalho de Melo AuthorDate: Mon, 3 Aug 2015 17:12:29 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 5 Aug 2015 10:52:19 -0300 perf trace: Do not show syscall tracepoint filter in the --no-syscalls case We were accessing trace->syscalls.events members even when that struct wasn't initialized, i.e. --no-syscalls was specified on the command line, fix it to show that, still in debug mode, when we have an event qualifier list, i.e. when we actually are doing subset syscall tracing. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Milian Wolff Cc: Namhyung Kim Cc: Stephane Eranian Fixes: 19867b6186f3 ("perf trace: Use event filters for the event qualifier list") Link: http://lkml.kernel.org/n/tip-7980ym6vujgh3yiai0cqzc88@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 06cfa93..3cfca93 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2394,9 +2394,10 @@ static int trace__run(struct trace *trace, int argc, const char **argv) err = trace__set_ev_qualifier_filter(trace); if (err < 0) goto out_errno; - } - pr_debug("%s\n", trace->syscalls.events.sys_exit->filter); + pr_debug("event qualifier tracepoint filter: %s\n", + trace->syscalls.events.sys_exit->filter); + } err = perf_evlist__apply_filters(evlist, &evsel); if (err < 0)