From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbbIRIty (ORCPT ); Fri, 18 Sep 2015 04:49:54 -0400 Received: from terminus.zytor.com ([198.137.202.10]:44749 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbbIRItw (ORCPT ); Fri, 18 Sep 2015 04:49:52 -0400 Date: Fri, 18 Sep 2015 01:49:10 -0700 From: tip-bot for Leo Yan Message-ID: Cc: mingo@kernel.org, peterz@infradead.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, hpa@zytor.com Reply-To: mingo@kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, hpa@zytor.com, leo.yan@linaro.org, linux-kernel@vger.kernel.org, tglx@linutronix.de In-Reply-To: <1442314605-14838-1-git-send-email-leo.yan@linaro.org> References: <1442314605-14838-1-git-send-email-leo.yan@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/fair: Remove unnecessary parameter for group_classify() Git-Commit-ID: 79a89f92cbe31ba6bc50caf211a7ac4d97d0f35f X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 79a89f92cbe31ba6bc50caf211a7ac4d97d0f35f Gitweb: http://git.kernel.org/tip/79a89f92cbe31ba6bc50caf211a7ac4d97d0f35f Author: Leo Yan AuthorDate: Tue, 15 Sep 2015 18:56:45 +0800 Committer: Ingo Molnar CommitDate: Fri, 18 Sep 2015 09:23:16 +0200 sched/fair: Remove unnecessary parameter for group_classify() The group_classify() function does not use the "env" parameter, so remove it. Also unify code to always use group_classify() to calculate group's load type. Signed-off-by: Leo Yan Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1442314605-14838-1-git-send-email-leo.yan@linaro.org Signed-off-by: Ingo Molnar --- kernel/sched/fair.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 80c62bf..4df37a4 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6273,9 +6273,9 @@ group_is_overloaded(struct lb_env *env, struct sg_lb_stats *sgs) return false; } -static enum group_type group_classify(struct lb_env *env, - struct sched_group *group, - struct sg_lb_stats *sgs) +static inline enum +group_type group_classify(struct sched_group *group, + struct sg_lb_stats *sgs) { if (sgs->group_no_capacity) return group_overloaded; @@ -6340,7 +6340,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, sgs->group_weight = group->group_weight; sgs->group_no_capacity = group_is_overloaded(env, sgs); - sgs->group_type = group_classify(env, group, sgs); + sgs->group_type = group_classify(group, sgs); } /** @@ -6474,7 +6474,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd group_has_capacity(env, &sds->local_stat) && (sgs->sum_nr_running > 1)) { sgs->group_no_capacity = 1; - sgs->group_type = group_overloaded; + sgs->group_type = group_classify(sg, sgs); } if (update_sd_pick_busiest(env, sds, sg, sgs)) {