From: tip-bot for Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
konrad.wilk@oracle.com, joerg.roedel@amd.com,
fujita.tomonori@lab.ntt.co.jp, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/iommu] x86, iommu: Fix IOMMU_INIT alignment rules
Date: Tue, 31 Aug 2010 07:27:58 GMT [thread overview]
Message-ID: <tip-7ac41ccf47d82569d26f34beab1dec92cc3b6347@git.kernel.org> (raw)
In-Reply-To: <1283191802-25086-1-git-send-email-konrad.wilk@oracle.com>
Commit-ID: 7ac41ccf47d82569d26f34beab1dec92cc3b6347
Gitweb: http://git.kernel.org/tip/7ac41ccf47d82569d26f34beab1dec92cc3b6347
Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
AuthorDate: Mon, 30 Aug 2010 14:10:02 -0400
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 31 Aug 2010 08:06:10 +0200
x86, iommu: Fix IOMMU_INIT alignment rules
This boot crash was observed:
DMA-API: preallocated 32768 debug entries
DMA-API: debugging enabled by kernel config
BUG: unable to handle kernel paging request at 19da8955
IP: [<f4ffffff>] 0xf4ffffff
*pde = 00000000
The crux of the failure was that even if we did not use any
of the .iommu_table section, the linker would still insert it
in the vmlinux file. This patch fixes that and also fixes the
runtime crash where we would try to access the array.
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
LKML-Reference: <1283191802-25086-1-git-send-email-konrad.wilk@oracle.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/vmlinux.lds.S | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 3f07c37..38e2b67 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -285,10 +285,9 @@ SECTIONS
.iommu_table : AT(ADDR(.iommu_table) - LOAD_OFFSET) {
__iommu_table = .;
*(.iommu_table)
- . = ALIGN(8);
__iommu_table_end = .;
}
-
+ . = ALIGN(8);
/*
* .exit.text is discard at runtime, not link time, to deal with
* references from .altinstructions and .eh_frame
prev parent reply other threads:[~2010-08-31 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 17:32 pci_iommu_init() crash Ingo Molnar
2010-08-30 14:32 ` Konrad Rzeszutek Wilk
2010-08-30 18:10 ` [PATCH] x86: Fix crash on X86 with IOMMU_INIT functinality Konrad Rzeszutek Wilk
2010-08-31 7:27 ` tip-bot for Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7ac41ccf47d82569d26f34beab1dec92cc3b6347@git.kernel.org \
--to=konrad.wilk@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome