From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdFGQAn (ORCPT ); Wed, 7 Jun 2017 12:00:43 -0400 Received: from terminus.zytor.com ([65.50.211.136]:60391 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbdFGQAl (ORCPT ); Wed, 7 Jun 2017 12:00:41 -0400 Date: Wed, 7 Jun 2017 08:56:02 -0700 From: tip-bot for Ravi Bangoria Message-ID: Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, alexander.shishkin@linux.intel.com, treeze.taeung@gmail.com, mingo@kernel.org, acme@redhat.com, tglx@linutronix.de, ravi.bangoria@linux.vnet.ibm.com, adam.stylinski@etegent.com, peterz@infradead.org Reply-To: alexander.shishkin@linux.intel.com, borntraeger@de.ibm.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, ravi.bangoria@linux.vnet.ibm.com, peterz@infradead.org, adam.stylinski@etegent.com, acme@redhat.com, treeze.taeung@gmail.com, mingo@kernel.org In-Reply-To: <20170505101417.2117-1-ravi.bangoria@linux.vnet.ibm.com> References: <20170505101417.2117-1-ravi.bangoria@linux.vnet.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf annotate: Fix failure when filename has special chars Git-Commit-ID: 7b4500bc519686712471924972022df88b12ff93 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 7b4500bc519686712471924972022df88b12ff93 Gitweb: http://git.kernel.org/tip/7b4500bc519686712471924972022df88b12ff93 Author: Ravi Bangoria AuthorDate: Fri, 5 May 2017 15:44:17 +0530 Committer: Arnaldo Carvalho de Melo CommitDate: Sat, 27 May 2017 10:10:18 -0300 perf annotate: Fix failure when filename has special chars When filename contains special chars, perf annotate fails with an error: $ perf annotate --vmlinux ./vmlinux\(test\) --stdio native_safe_halt sh: -c: line 0: syntax error near unexpected token `(' sh: -c: line 0: `objdump --start-address=0xffffffff8184e840 --stop-address=0xffffffff8184e848 -l -d --no-show-raw -S -C ./vmlinux(test) 2>/dev/null|grep -v ./vmlinux(test):|expand' Fix it by surrounding filename in double quotes. Signed-off-by: Ravi Bangoria Cc: Adam Stylinski Cc: Alexander Shishkin Cc: Christian Borntraeger Cc: Peter Zijlstra Cc: Taeung Song Link: http://lkml.kernel.org/r/20170505101417.2117-1-ravi.bangoria@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 683f834..07d5608 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -1429,7 +1429,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na snprintf(command, sizeof(command), "%s %s%s --start-address=0x%016" PRIx64 " --stop-address=0x%016" PRIx64 - " -l -d %s %s -C %s 2>/dev/null|grep -v %s:|expand", + " -l -d %s %s -C \"%s\" 2>/dev/null|grep -v \"%s:\"|expand", objdump_path ? objdump_path : "objdump", disassembler_style ? "-M " : "", disassembler_style ? disassembler_style : "",