From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756784AbcKXEQB (ORCPT ); Wed, 23 Nov 2016 23:16:01 -0500 Received: from terminus.zytor.com ([198.137.202.10]:49552 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbcKXEP7 (ORCPT ); Wed, 23 Nov 2016 23:15:59 -0500 Date: Wed, 23 Nov 2016 20:15:30 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: namhyung@kernel.org, jmario@redhat.com, dzickus@redhat.com, dsahern@gmail.com, mingo@kernel.org, a.p.zijlstra@chello.nl, jolsa@redhat.com, jolsa@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, tglx@linutronix.de, acme@redhat.com Reply-To: mingo@kernel.org, jolsa@redhat.com, a.p.zijlstra@chello.nl, dzickus@redhat.com, dsahern@gmail.com, jmario@redhat.com, namhyung@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org, acme@redhat.com, tglx@linutronix.de, jolsa@kernel.org, hpa@zytor.com In-Reply-To: <1479764011-10732-2-git-send-email-jolsa@kernel.org> References: <1479764011-10732-2-git-send-email-jolsa@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Show event fd in debug output Git-Commit-ID: 7b4b82bced0755aecc026d8c14c2608aa0f9e89b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 7b4b82bced0755aecc026d8c14c2608aa0f9e89b Gitweb: http://git.kernel.org/tip/7b4b82bced0755aecc026d8c14c2608aa0f9e89b Author: Jiri Olsa AuthorDate: Mon, 21 Nov 2016 22:33:26 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 23 Nov 2016 10:44:03 -0300 perf tools: Show event fd in debug output It is useful for debug to see file descriptors for each event. Before: $ perf stat -vvv -e cycles,cache-misses ls ... sys_perf_event_open: pid 12146 cpu -1 group_fd -1 flags 0x8 ... sys_perf_event_open: pid 12146 cpu -1 group_fd 3 flags 0x8 sys_perf_event_open failed, error -13 Now: $ perf stat -vvv -e cycles,cache-misses ls ... sys_perf_event_open: pid 12858 cpu -1 group_fd -1 flags 0x8 = 3 ... sys_perf_event_open: pid 12858 cpu -1 group_fd 3 flags 0x8 sys_perf_event_open failed, error -13 Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: David Ahern Cc: Don Zickus Cc: Joe Mario Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1479764011-10732-2-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index e58a2fb..b2365a63 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1481,7 +1481,7 @@ retry_sample_id: group_fd = get_group_fd(evsel, cpu, thread); retry_open: - pr_debug2("sys_perf_event_open: pid %d cpu %d group_fd %d flags %#lx\n", + pr_debug2("sys_perf_event_open: pid %d cpu %d group_fd %d flags %#lx", pid, cpus->map[cpu], group_fd, flags); FD(evsel, cpu, thread) = sys_perf_event_open(&evsel->attr, @@ -1490,11 +1490,13 @@ retry_open: group_fd, flags); if (FD(evsel, cpu, thread) < 0) { err = -errno; - pr_debug2("sys_perf_event_open failed, error %d\n", + pr_debug2("\nsys_perf_event_open failed, error %d\n", err); goto try_fallback; } + pr_debug2(" = %d\n", FD(evsel, cpu, thread)); + if (evsel->bpf_fd >= 0) { int evt_fd = FD(evsel, cpu, thread); int bpf_fd = evsel->bpf_fd;