From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbdKUIq6 (ORCPT ); Tue, 21 Nov 2017 03:46:58 -0500 Received: from terminus.zytor.com ([65.50.211.136]:33069 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbdKUIq5 (ORCPT ); Tue, 21 Nov 2017 03:46:57 -0500 Date: Tue, 21 Nov 2017 00:41:21 -0800 From: tip-bot for Dave Hansen Message-ID: Cc: dvlasenk@redhat.com, torvalds@linux-foundation.org, tglx@linutronix.de, luto@kernel.org, jpoimboe@redhat.com, mingo@kernel.org, brgerst@gmail.com, peterz@infradead.org, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, hpa@zytor.com, bp@alien8.de Reply-To: tglx@linutronix.de, luto@kernel.org, torvalds@linux-foundation.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, bp@alien8.de, mingo@kernel.org, jpoimboe@redhat.com, brgerst@gmail.com, peterz@infradead.org In-Reply-To: <20171111001232.94813E58@viggo.jf.intel.com> References: <20171111001232.94813E58@viggo.jf.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/pkeys/selftests: Fix protection keys write() warning Git-Commit-ID: 7b659ee3e1fe0e8eb39730afb903c64e25490ec4 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 7b659ee3e1fe0e8eb39730afb903c64e25490ec4 Gitweb: https://git.kernel.org/tip/7b659ee3e1fe0e8eb39730afb903c64e25490ec4 Author: Dave Hansen AuthorDate: Fri, 10 Nov 2017 16:12:32 -0800 Committer: Ingo Molnar CommitDate: Tue, 21 Nov 2017 09:34:52 +0100 x86/pkeys/selftests: Fix protection keys write() warning write() is marked as having a must-check return value. Check it and abort if we fail to write an error message from a signal handler. Signed-off-by: Dave Hansen Acked-by: Thomas Gleixner Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20171111001232.94813E58@viggo.jf.intel.com Signed-off-by: Ingo Molnar --- tools/testing/selftests/x86/pkey-helpers.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/pkey-helpers.h b/tools/testing/selftests/x86/pkey-helpers.h index 3818f25..b3cb767 100644 --- a/tools/testing/selftests/x86/pkey-helpers.h +++ b/tools/testing/selftests/x86/pkey-helpers.h @@ -30,6 +30,7 @@ static inline void sigsafe_printf(const char *format, ...) if (!dprint_in_signal) { vprintf(format, ap); } else { + int ret; int len = vsnprintf(dprint_in_signal_buffer, DPRINT_IN_SIGNAL_BUF_SIZE, format, ap); @@ -39,7 +40,9 @@ static inline void sigsafe_printf(const char *format, ...) */ if (len > DPRINT_IN_SIGNAL_BUF_SIZE) len = DPRINT_IN_SIGNAL_BUF_SIZE; - write(1, dprint_in_signal_buffer, len); + ret = write(1, dprint_in_signal_buffer, len); + if (ret < 0) + abort(); } va_end(ap); }