From: tip-bot for John Garry <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: john.garry@huawei.com, mingo@kernel.org, peterz@infradead.org,
tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: [tip:sched/core] sched/completions/Documentation: Fix a couple of punctuation nits
Date: Thu, 11 Oct 2018 01:39:50 -0700 [thread overview]
Message-ID: <tip-7b6abce7e1e69b6d8dc5d40a8cb9ddaeb400427c@git.kernel.org> (raw)
In-Reply-To: <1539183392-239389-1-git-send-email-john.garry@huawei.com>
Commit-ID: 7b6abce7e1e69b6d8dc5d40a8cb9ddaeb400427c
Gitweb: https://git.kernel.org/tip/7b6abce7e1e69b6d8dc5d40a8cb9ddaeb400427c
Author: John Garry <john.garry@huawei.com>
AuthorDate: Wed, 10 Oct 2018 22:56:32 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 11 Oct 2018 10:36:22 +0200
sched/completions/Documentation: Fix a couple of punctuation nits
This patch fixes a couple of punctuation nits which can make the document
more correct and readable.
Also missing "()" are added to some function references for consistency.
Signed-off-by: John Garry <john.garry@huawei.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: corbet@lwn.net
Cc: linux-doc@vger.kernel.org
Link: http://lkml.kernel.org/r/1539183392-239389-1-git-send-email-john.garry@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
Documentation/scheduler/completion.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/scheduler/completion.txt b/Documentation/scheduler/completion.txt
index 656cf803c006..108bd0f264b3 100644
--- a/Documentation/scheduler/completion.txt
+++ b/Documentation/scheduler/completion.txt
@@ -116,7 +116,7 @@ A typical usage scenario is:
This is not implying any temporal order on wait_for_completion() and the
call to complete() - if the call to complete() happened before the call
to wait_for_completion() then the waiting side simply will continue
-immediately as all dependencies are satisfied if not it will block until
+immediately as all dependencies are satisfied; if not, it will block until
completion is signaled by complete().
Note that wait_for_completion() is calling spin_lock_irq()/spin_unlock_irq(),
@@ -131,7 +131,7 @@ wait_for_completion():
The default behavior is to wait without a timeout and to mark the task as
uninterruptible. wait_for_completion() and its variants are only safe
in process context (as they can sleep) but not in atomic context,
-interrupt context, with disabled irqs. or preemption is disabled - see also
+interrupt context, with disabled irqs, or preemption is disabled - see also
try_wait_for_completion() below for handling completion in atomic/interrupt
context.
@@ -224,7 +224,7 @@ queue spinlock. Any such concurrent calls to complete() or complete_all()
probably are a design bug.
Signaling completion from hard-irq context is fine as it will appropriately
-lock with spin_lock_irqsave/spin_unlock_irqrestore and it will never sleep.
+lock with spin_lock_irqsave()/spin_unlock_irqrestore() and it will never sleep.
try_wait_for_completion()/completion_done():
next prev parent reply other threads:[~2018-10-11 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 14:56 [PATCH] docs/completion.txt: " John Garry
2018-10-10 15:47 ` Randy Dunlap
2018-10-11 8:39 ` tip-bot for John Garry [this message]
2018-10-11 8:40 ` [tip:sched/core] sched/completions/Documentation: Clean up the document some more tip-bot for Ingo Molnar
2018-10-11 22:06 ` Ingo Molnar
2018-10-11 15:29 ` [PATCH] docs/completion.txt: Fix a couple of punctuation nits Matthew Wilcox
2018-10-11 15:41 ` Peter Zijlstra
2018-10-11 18:46 ` Jani Nikula
2018-10-12 9:32 ` Peter Zijlstra
2018-10-12 17:27 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7b6abce7e1e69b6d8dc5d40a8cb9ddaeb400427c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome