From: tip-bot for Yinghai Lu <yinghai@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
yinghai@kernel.org, peterz@infradead.org,
benh@kernel.crashing.org, linux@arm.linux.org.uk,
tglx@linutronix.de, sfr@canb.auug.org.au, mingo@elte.hu
Subject: [tip:core/memblock] arm, memblock: Fix the sparsemem build
Date: Thu, 16 Sep 2010 14:43:26 GMT [thread overview]
Message-ID: <tip-7c996361ef0d02ef8c1435902c909d14195adcdc@git.kernel.org> (raw)
In-Reply-To: <4C91C544.5050907@kernel.org>
Commit-ID: 7c996361ef0d02ef8c1435902c909d14195adcdc
Gitweb: http://git.kernel.org/tip/7c996361ef0d02ef8c1435902c909d14195adcdc
Author: Yinghai Lu <yinghai@kernel.org>
AuthorDate: Thu, 16 Sep 2010 00:20:36 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 16 Sep 2010 09:35:12 +0200
arm, memblock: Fix the sparsemem build
Stephen Rothwell reported this build failure:
arch/arm/mm/init.c: In function 'arm_memory_present':
arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
Caused by commit 719c1514f2 ("memblock/arm: Use new accessors")
which forgot a closing brace on a new for_each_memblock() in
arm_memory_present().
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Russell King <linux@arm.linux.org.uk>
LKML-Reference: <4C91C544.5050907@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/arm/mm/init.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 8504906..d6022d1 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -249,9 +249,8 @@ static void arm_memory_present(void)
static void arm_memory_present(void)
{
struct memblock_region *reg;
- int i;
- for_each_memblock(memory, reg) {
+ for_each_memblock(memory, reg)
memory_present(0, memblock_region_base_pfn(reg),
memblock_region_end_pfn(reg));
}
prev parent reply other threads:[~2010-09-16 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 14:29 linux-next: build failure after merge of the final tree (tip tree related) Stephen Rothwell
2010-09-16 6:32 ` Stephen Rothwell
2010-09-16 6:39 ` Ingo Molnar
2010-09-16 7:08 ` Russell King - ARM Linux
2010-09-16 7:34 ` Ingo Molnar
2010-09-16 9:02 ` Russell King - ARM Linux
2010-09-16 7:09 ` Stephen Rothwell
2010-09-16 7:20 ` Yinghai Lu
2010-09-16 7:27 ` Stephen Rothwell
2010-09-16 14:43 ` tip-bot for Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7c996361ef0d02ef8c1435902c909d14195adcdc@git.kernel.org \
--to=yinghai@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome