From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757521AbbDVTEE (ORCPT ); Wed, 22 Apr 2015 15:04:04 -0400 Received: from terminus.zytor.com ([198.137.202.10]:41051 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728AbbDVTEC (ORCPT ); Wed, 22 Apr 2015 15:04:02 -0400 Date: Wed, 22 Apr 2015 12:03:38 -0700 From: tip-bot for Joe Perches Message-ID: Cc: tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, joe@perches.com Reply-To: tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, john.stultz@linaro.org, joe@perches.com, linux-kernel@vger.kernel.org In-Reply-To: <1429295958.2850.104.camel@perches.com> References: <1429295958.2850.104.camel@perches.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] timer_list: Reduce SEQ_printf footprint Git-Commit-ID: 7de4e74430139f2484cb16cedf6c281d1a5a696e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 7de4e74430139f2484cb16cedf6c281d1a5a696e Gitweb: http://git.kernel.org/tip/7de4e74430139f2484cb16cedf6c281d1a5a696e Author: Joe Perches AuthorDate: Fri, 17 Apr 2015 11:39:18 -0700 Committer: Thomas Gleixner CommitDate: Wed, 22 Apr 2015 12:03:39 +0200 timer_list: Reduce SEQ_printf footprint This macro can be converted to a static function to reduce object size. (x86-64 defconfig) $ size kernel/time/timer_list.o* text data bss dec hex filename 6583 8 0 6591 19bf kernel/time/timer_list.o.old 4647 8 0 4655 122f kernel/time/timer_list.o.new Signed-off-by: Joe Perches Cc: John Stultz Link: http://lkml.kernel.org/r/1429295958.2850.104.camel@perches.com Signed-off-by: Thomas Gleixner --- kernel/time/timer_list.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c index e878c2e..5960af21 100644 --- a/kernel/time/timer_list.c +++ b/kernel/time/timer_list.c @@ -35,13 +35,20 @@ DECLARE_PER_CPU(struct hrtimer_cpu_base, hrtimer_bases); * This allows printing both to /proc/timer_list and * to the console (on SysRq-Q): */ -#define SEQ_printf(m, x...) \ - do { \ - if (m) \ - seq_printf(m, x); \ - else \ - printk(x); \ - } while (0) +__printf(2, 3) +static void SEQ_printf(struct seq_file *m, const char *fmt, ...) +{ + va_list args; + + va_start(args, fmt); + + if (m) + seq_vprintf(m, fmt, args); + else + vprintk(fmt, args); + + va_end(args); +} static void print_name_offset(struct seq_file *m, void *sym) {