From: tip-bot for David Rientjes <rientjes@google.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
steiner@sgi.com, yanmin_zhang@linux.intel.com,
tglx@linutronix.de, rientjes@google.com, mingo@elte.hu
Subject: [tip:x86/urgent] x86, srat: do not register nodes beyond e820 map
Date: Wed, 6 May 2009 08:58:00 GMT [thread overview]
Message-ID: <tip-7eccf7b227b6d3b1745b937ce35efc9c27f9b0e5@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0905051248150.20021@chino.kir.corp.google.com>
Commit-ID: 7eccf7b227b6d3b1745b937ce35efc9c27f9b0e5
Gitweb: http://git.kernel.org/tip/7eccf7b227b6d3b1745b937ce35efc9c27f9b0e5
Author: David Rientjes <rientjes@google.com>
AuthorDate: Tue, 5 May 2009 12:50:02 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 6 May 2009 10:49:07 +0200
x86, srat: do not register nodes beyond e820 map
The mem= option will truncate the memory map at a specified address so
it's not possible to register nodes with memory beyond the e820 upper
bound.
unparse_node() is only called when then node had memory associated with
it, although with the mem= option it is no longer addressable.
[ Impact: fix boot hang on certain (large) systems ]
Reported-by: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Jack Steiner <steiner@sgi.com>
LKML-Reference: <alpine.DEB.2.00.0905051248150.20021@chino.kir.corp.google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/srat_64.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c
index 33c5fa5..0176595 100644
--- a/arch/x86/mm/srat_64.c
+++ b/arch/x86/mm/srat_64.c
@@ -361,6 +361,7 @@ static void __init unparse_node(int node)
{
int i;
node_clear(node, nodes_parsed);
+ node_clear(node, cpu_nodes_parsed);
for (i = 0; i < MAX_LOCAL_APIC; i++) {
if (apicid_to_node[i] == node)
apicid_to_node[i] = NUMA_NO_NODE;
next prev parent reply other threads:[~2009-05-06 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 3:15 [PATCH] Fix early panic issue on machines with memless node Zhang, Yanmin
2009-05-05 3:32 ` David Rientjes
2009-05-05 5:55 ` Zhang, Yanmin
2009-05-05 16:36 ` Jack Steiner
2009-05-05 19:50 ` [patch] srat: do not register nodes beyond e820 map David Rientjes
2009-05-06 8:58 ` tip-bot for David Rientjes [this message]
2009-05-05 19:52 ` [PATCH] Fix early panic issue on machines with memless node David Rientjes
2009-05-05 20:27 ` Jack Steiner
2009-05-05 20:41 ` David Rientjes
2009-05-06 5:19 ` Zhang, Yanmin
2009-05-06 14:38 ` Jack Steiner
2009-05-06 8:50 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-7eccf7b227b6d3b1745b937ce35efc9c27f9b0e5@git.kernel.org \
--to=rientjes@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®