From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbeAQQeu (ORCPT ); Wed, 17 Jan 2018 11:34:50 -0500 Received: from terminus.zytor.com ([65.50.211.136]:36279 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754007AbeAQQes (ORCPT ); Wed, 17 Jan 2018 11:34:48 -0500 Date: Wed, 17 Jan 2018 08:31:32 -0800 From: tip-bot for Taeung Song Message-ID: Cc: namhyung@kernel.org, treeze.taeung@gmail.com, hpa@zytor.com, akpm@linux-foundation.org, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org Reply-To: mingo@kernel.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, treeze.taeung@gmail.com, hpa@zytor.com, akpm@linux-foundation.org, acme@redhat.com, tglx@linutronix.de In-Reply-To: <1493218540-12296-1-git-send-email-treeze.taeung@gmail.com> References: <20180112004823.012918807@goodmis.org> <1493218540-12296-1-git-send-email-treeze.taeung@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial() Git-Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 Gitweb: https://git.kernel.org/tip/806efaed3cacab1521895d20bb3b5ed610909299 Author: Taeung Song AuthorDate: Thu, 11 Jan 2018 19:47:50 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:22:57 -0300 tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial() Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement. Reported-by: Namhyung Kim Acked-by: Namhyung Kim Signed-off-by: Taeung Song Cc: Andrew Morton Link: http://lkml.kernel.org/r/20180112004823.012918807@goodmis.org Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.taeung@gmail.com Signed-off-by: Steven Rostedt Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/parse-filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 2410afd..2b9048f 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, case FILTER_TRIVIAL_FALSE: if (filter_type->filter->boolean.value) continue; + break; case FILTER_TRIVIAL_TRUE: if (!filter_type->filter->boolean.value) continue;