From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226oNlR5IGyMQaxEEQplU9uJbHVaoQ5hsPL9NU1tq6Gttis6Y9WYBaMN1YofwR+1lU/x1NHm ARC-Seal: i=1; a=rsa-sha256; t=1517321889; cv=none; d=google.com; s=arc-20160816; b=tbzZJEENRoe6swPnZz5RIvgI8xrejSATeYnKSMw+78Q/dPvlRncdJ5J+qmGRAsFjXb A+KRE8Qhi0e4Je/GvPZWHybAQMlE7kJndeNZ2yA2FEK5HFTsIPDnQxzN6SUPYoMcGP6p 6JDk2X6VrxkkcAOsE5uWCkk0VKu3MibyPCU2cMxfj66ge5xe3yJT16MeeH07evKUb3VN YUFY9BNbPya6RM5TTIJrT+kJymvVF/FPRJd2fKaTk7y5ZSLN8Jd7fpkeONacKsgopBsk pnsav5w2HM2cij3W+vm+LUKKkenZq0yfTpVAGykrWkHSvgZZD5TlJnpI08tyisRjR0jn Q10w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=precedence:content-disposition:content-transfer-encoding :mime-version:robot-unsubscribe:robot-id:git-commit-id:subject:to :references:in-reply-to:reply-to:cc:message-id:from:sender:date :arc-authentication-results; bh=FLJLtEbjNxRPv5oVv7GlwmDmzSzcMpac+dzDOaazHRE=; b=AZlugtKkNNR0adZ07NUIsoXANHjxHvSeG5dLDJSBptZowKTxfy2RojcVUzzH3zcWlP 7J5qgH583yTysDg2EM0v2BW2GwzM7rb5D81C+vOCTAJAHog9G7UuwV941BEr9cKPByf2 y67KPMG3GqkM6VuxbR0uybSnMDCj+qmpMSnnXPSHcCx6ZLSgKN2GnjtHuaAa0/mT5pgE xJzI1dMRQJ++kP2thYBGFAG/CD/7XUuVRibOMoc+2PUK7Dsu5aE5RlOuddx8/R6jV45D mO7kQOjFVtjnqWO98tfqz6fEZyupvNjTXK1yI/qu0POtcFfXWGebHWW5cKtvfw2O5Vnp r7Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tipbot@zytor.com designates 65.50.211.136 as permitted sender) smtp.mailfrom=tipbot@zytor.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of tipbot@zytor.com designates 65.50.211.136 as permitted sender) smtp.mailfrom=tipbot@zytor.com Date: Tue, 30 Jan 2018 06:13:43 -0800 Sender: tip tree robot From: tip-bot for Josh Poimboeuf Message-ID: Cc: jgross@suse.com, jpoimboe@redhat.com, dave.hansen@linux.intel.com, tglx@linutronix.de, hpa@zytor.com, linux@roeck-us.net, bp@alien8.de, dwmw2@infradead.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, luto@kernel.org, peterz@infradead.org, mingo@kernel.org Reply-To: torvalds@linux-foundation.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@kernel.org, peterz@infradead.org, jgross@suse.com, jpoimboe@redhat.com, dave.hansen@linux.intel.com, tglx@linutronix.de, hpa@zytor.com, linux@roeck-us.net, bp@alien8.de, dwmw2@infradead.org In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] objtool: Warn on stripped section symbol Git-Commit-ID: 830c1e3d16b2c1733cd1ec9c8f4d47a398ae31bc X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591006828489147946?= X-GMAIL-MSGID: =?utf-8?q?1591027317180555546?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Commit-ID: 830c1e3d16b2c1733cd1ec9c8f4d47a398ae31bc Gitweb: https://git.kernel.org/tip/830c1e3d16b2c1733cd1ec9c8f4d47a398ae31bc Author: Josh Poimboeuf AuthorDate: Mon, 29 Jan 2018 22:00:41 -0600 Committer: Ingo Molnar CommitDate: Tue, 30 Jan 2018 15:09:23 +0100 objtool: Warn on stripped section symbol With the following fix: 2a0098d70640 ("objtool: Fix seg fault with gold linker") ... a seg fault was avoided, but the original seg fault condition in objtool wasn't fixed. Replace the seg fault with an error message. Suggested-by: Ingo Molnar Signed-off-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Dave Hansen Cc: David Woodhouse Cc: Greg Kroah-Hartman Cc: Guenter Roeck Cc: H. Peter Anvin Cc: Juergen Gross Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/dc4585a70d6b975c99fc51d1957ccdde7bd52f3a.1517284349.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- tools/objtool/orc_gen.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/objtool/orc_gen.c b/tools/objtool/orc_gen.c index e61fe70..18384d9 100644 --- a/tools/objtool/orc_gen.c +++ b/tools/objtool/orc_gen.c @@ -98,6 +98,11 @@ static int create_orc_entry(struct section *u_sec, struct section *ip_relasec, struct orc_entry *orc; struct rela *rela; + if (!insn_sec->sym) { + WARN("missing symbol for section %s", insn_sec->name); + return -1; + } + /* populate ORC data */ orc = (struct orc_entry *)u_sec->data->d_buf + idx; memcpy(orc, o, sizeof(*orc));