From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756252AbcAIQdS (ORCPT ); Sat, 9 Jan 2016 11:33:18 -0500 Received: from terminus.zytor.com ([198.137.202.10]:42030 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbcAIQdQ (ORCPT ); Sat, 9 Jan 2016 11:33:16 -0500 Date: Sat, 9 Jan 2016 08:32:39 -0800 From: tip-bot for Stephane Eranian Message-ID: Cc: hpa@zytor.com, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, jolsa@kernel.org, ak@linux.intel.com, kan.liang@intel.com, peterz@infradead.org Reply-To: hpa@zytor.com, tglx@linutronix.de, acme@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, jolsa@kernel.org, ak@linux.intel.com, kan.liang@intel.com, peterz@infradead.org In-Reply-To: <1452106201-13073-1-git-send-email-eranian@google.com> References: <1452106201-13073-1-git-send-email-eranian@google.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf pmu: fix alias-> snapshot missing initialization bug Git-Commit-ID: 84530920de3c6ccb92c6661da784f6cdb66d3304 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 84530920de3c6ccb92c6661da784f6cdb66d3304 Gitweb: http://git.kernel.org/tip/84530920de3c6ccb92c6661da784f6cdb66d3304 Author: Stephane Eranian AuthorDate: Wed, 6 Jan 2016 19:50:01 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Jan 2016 20:11:16 -0300 perf pmu: fix alias->snapshot missing initialization bug This patch fixes a bug in __perf_pmu__new_alias() whereby the alias->snapshot field was not initialized to false. This led to random alias->snapshot value for an alias and was breaking some measurements such as: $ perf stat -a -e uncore_imc/data_reads/ -I 1000 sleep 100 Because the event ended up being treated as snapshot mode, when it is not. Signed-off-by: Stephane Eranian Cc: Andi Kleen Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1452106201-13073-1-git-send-email-eranian@google.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/pmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index e4b173d..b597bcc 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -220,6 +220,7 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, alias->scale = 1.0; alias->unit[0] = '\0'; alias->per_pkg = false; + alias->snapshot = false; ret = parse_events_terms(&alias->terms, val); if (ret) {