From: tip-bot for Borislav Petkov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: vitezslav@samel.cz, linux-kernel@vger.kernel.org,
mingo@kernel.org, bp@suse.de, hpa@zytor.com, ashok.raj@intel.com,
tglx@linutronix.de
Subject: [tip:x86/urgent] x86/microcode/intel: Save microcode patch unconditionally
Date: Tue, 24 Apr 2018 00:51:50 -0700 [thread overview]
Message-ID: <tip-84749d83758af6576552046b215b9b7f37f9556b@git.kernel.org> (raw)
In-Reply-To: <20180421081930.15741-1-bp@alien8.de>
Commit-ID: 84749d83758af6576552046b215b9b7f37f9556b
Gitweb: https://git.kernel.org/tip/84749d83758af6576552046b215b9b7f37f9556b
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Sat, 21 Apr 2018 10:19:29 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 24 Apr 2018 09:48:22 +0200
x86/microcode/intel: Save microcode patch unconditionally
save_mc_for_early() was a no-op on !CONFIG_HOTPLUG_CPU but the
generic_load_microcode() path saves the microcode patches it has found into
the cache of patches which is used for late loading too. Regardless of
whether CPU hotplug is used or not.
Make the saving unconditional so that late loading can find the proper
patch.
Reported-by: Vitezslav Samel <vitezslav@samel.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Vitezslav Samel <vitezslav@samel.cz>
Tested-by: Ashok Raj <ashok.raj@intel.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180418081140.GA2439@pc11.op.pod.cz
Link: https://lkml.kernel.org/r/20180421081930.15741-1-bp@alien8.de
---
arch/x86/kernel/cpu/microcode/intel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index 32b8e5724f96..1c2cfa0644aa 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -485,7 +485,6 @@ static void show_saved_mc(void)
*/
static void save_mc_for_early(u8 *mc, unsigned int size)
{
-#ifdef CONFIG_HOTPLUG_CPU
/* Synchronization during CPU hotplug. */
static DEFINE_MUTEX(x86_cpu_microcode_mutex);
@@ -495,7 +494,6 @@ static void save_mc_for_early(u8 *mc, unsigned int size)
show_saved_mc();
mutex_unlock(&x86_cpu_microcode_mutex);
-#endif
}
static bool load_builtin_intel_microcode(struct cpio_data *cp)
prev parent reply other threads:[~2018-04-24 7:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 8:11 4.15.17 regression: bisected: timeout during microcode update Vitezslav Samel
2018-04-18 10:07 ` Borislav Petkov
2018-04-18 12:08 ` Vitezslav Samel
2018-04-18 12:22 ` Borislav Petkov
2018-04-18 13:53 ` Raj, Ashok
2018-04-18 16:14 ` Borislav Petkov
2018-04-19 5:35 ` Vitezslav Samel
2018-04-19 7:22 ` Raj, Ashok
2018-04-19 10:48 ` Borislav Petkov
2018-04-19 12:02 ` Vitezslav Samel
2018-04-19 12:18 ` Borislav Petkov
2018-04-19 12:32 ` Raj, Ashok
2018-04-19 13:48 ` Vitezslav Samel
2018-04-19 13:46 ` Vitezslav Samel
2018-04-19 16:37 ` Borislav Petkov
2018-04-20 6:20 ` Vitezslav Samel
2018-04-20 9:52 ` Borislav Petkov
2018-04-20 10:01 ` Vitezslav Samel
2018-04-20 10:32 ` Borislav Petkov
2018-04-20 10:34 ` [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally Borislav Petkov
2018-04-20 10:54 ` Vitezslav Samel
2018-04-20 15:59 ` Raj, Ashok
2018-04-20 10:37 ` [PATCH 2/2] x86/microcode: Do not exit early from __reload_late() Borislav Petkov
2018-04-20 10:54 ` Vitezslav Samel
2018-04-20 16:00 ` Raj, Ashok
2018-04-21 8:19 ` [PATCH 1/2] x86/microcode/intel: Save microcode patch unconditionally Borislav Petkov
2018-04-21 8:19 ` [PATCH 2/2] x86/microcode: Do not exit early from __reload_late() Borislav Petkov
2018-04-24 7:52 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2018-04-24 7:51 ` tip-bot for Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-84749d83758af6576552046b215b9b7f37f9556b@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vitezslav@samel.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome