From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbbJNPaV (ORCPT ); Wed, 14 Oct 2015 11:30:21 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60903 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbbJNPaT (ORCPT ); Wed, 14 Oct 2015 11:30:19 -0400 Date: Wed, 14 Oct 2015 08:29:22 -0700 From: tip-bot for Andy Lutomirski Message-ID: Cc: bp@suse.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, luto@kernel.org, dvlasenk@redhat.com, tglx@linutronix.de, bp@alien8.de, brgerst@gmail.com Reply-To: mingo@kernel.org, torvalds@linux-foundation.org, bp@suse.de, linux-kernel@vger.kernel.org, hpa@zytor.com, brgerst@gmail.com, tglx@linutronix.de, bp@alien8.de, dvlasenk@redhat.com, luto@kernel.org, peterz@infradead.org In-Reply-To: <3335040bdd40d2bca4b1a28a3f8b165361c801b7.1444696194.git.luto@kernel.org> References: <3335040bdd40d2bca4b1a28a3f8b165361c801b7.1444696194.git.luto@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] selftests/x86: Style fixes for the 'unwind_vdso' test Git-Commit-ID: 893a3ec27e1dae62a904f78d53244001979748a6 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 893a3ec27e1dae62a904f78d53244001979748a6 Gitweb: http://git.kernel.org/tip/893a3ec27e1dae62a904f78d53244001979748a6 Author: Andy Lutomirski AuthorDate: Mon, 12 Oct 2015 17:32:12 -0700 Committer: Ingo Molnar CommitDate: Wed, 14 Oct 2015 16:56:28 +0200 selftests/x86: Style fixes for the 'unwind_vdso' test Checkpatch is really quite bad for user code like this, but it caught two legit style issues. Reported-by: Borislav Petkov Signed-off-by: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/3335040bdd40d2bca4b1a28a3f8b165361c801b7.1444696194.git.luto@kernel.org Signed-off-by: Ingo Molnar --- tools/testing/selftests/x86/unwind_vdso.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/x86/unwind_vdso.c b/tools/testing/selftests/x86/unwind_vdso.c index 5992ff2..00a26a8 100644 --- a/tools/testing/selftests/x86/unwind_vdso.c +++ b/tools/testing/selftests/x86/unwind_vdso.c @@ -134,7 +134,7 @@ _Unwind_Reason_Code trace_fn(struct _Unwind_Context * ctx, void *opaque) static void sigtrap(int sig, siginfo_t *info, void *ctx_void) { - ucontext_t *ctx = (ucontext_t*)ctx_void; + ucontext_t *ctx = (ucontext_t *)ctx_void; struct unwind_state state; unsigned long ip = ctx->uc_mcontext.gregs[REG_EIP]; @@ -192,7 +192,9 @@ int main() * affected by libc/19006 (https://sourceware.org/PR19006). */ printf("[WARN]\tsyscall(2) didn't enter AT_SYSINFO\n"); - } if (get_eflags() & X86_EFLAGS_TF) { + } + + if (get_eflags() & X86_EFLAGS_TF) { printf("[FAIL]\tTF is still set\n"); nerrs++; }