From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbdLLPLf (ORCPT ); Tue, 12 Dec 2017 10:11:35 -0500 Received: from terminus.zytor.com ([65.50.211.136]:55453 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbdLLPLa (ORCPT ); Tue, 12 Dec 2017 10:11:30 -0500 Date: Tue, 12 Dec 2017 07:07:53 -0800 From: tip-bot for Mark Rutland Message-ID: Cc: joe@perches.com, hpa@zytor.com, peterz@infradead.org, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, apw@canonical.com, mark.rutland@arm.com, tglx@linutronix.de Reply-To: paulmck@linux.vnet.ibm.com, peterz@infradead.org, joe@perches.com, hpa@zytor.com, mark.rutland@arm.com, tglx@linutronix.de, mingo@kernel.org, torvalds@linux-foundation.org, apw@canonical.com, linux-kernel@vger.kernel.org In-Reply-To: <20171127103824.36526-5-mark.rutland@arm.com> References: <20171127103824.36526-5-mark.rutland@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/urgent] checkpatch: Remove ACCESS_ONCE() warning Git-Commit-ID: 8cb562b1d56fad42cbee44bdc9bc64cea41a0a8c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 8cb562b1d56fad42cbee44bdc9bc64cea41a0a8c Gitweb: https://git.kernel.org/tip/8cb562b1d56fad42cbee44bdc9bc64cea41a0a8c Author: Mark Rutland AuthorDate: Mon, 27 Nov 2017 10:38:24 +0000 Committer: Ingo Molnar CommitDate: Tue, 12 Dec 2017 13:22:10 +0100 checkpatch: Remove ACCESS_ONCE() warning Now that ACCESS_ONCE() has been excised from the kernel, any uses will result in a build error, and we no longer need to whine about it in checkpatch. This patch removes the newly redundant warning. Tested-by: Paul E. McKenney Signed-off-by: Mark Rutland Acked-by: Joe Perches Cc: Andy Whitcroft Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: acme@redhat.com Link: http://lkml.kernel.org/r/20171127103824.36526-5-mark.rutland@arm.com Signed-off-by: Ingo Molnar --- scripts/checkpatch.pl | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 040aa79..31031f1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6233,28 +6233,6 @@ sub process { } } -# whine about ACCESS_ONCE - if ($^V && $^V ge 5.10.0 && - $line =~ /\bACCESS_ONCE\s*$balanced_parens\s*(=(?!=))?\s*($FuncArg)?/) { - my $par = $1; - my $eq = $2; - my $fun = $3; - $par =~ s/^\(\s*(.*)\s*\)$/$1/; - if (defined($eq)) { - if (WARN("PREFER_WRITE_ONCE", - "Prefer WRITE_ONCE(, ) over ACCESS_ONCE() = \n" . $herecurr) && - $fix) { - $fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)\s*$eq\s*\Q$fun\E/WRITE_ONCE($par, $fun)/; - } - } else { - if (WARN("PREFER_READ_ONCE", - "Prefer READ_ONCE() over ACCESS_ONCE()\n" . $herecurr) && - $fix) { - $fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)/READ_ONCE($par)/; - } - } - } - # check for mutex_trylock_recursive usage if ($line =~ /mutex_trylock_recursive/) { ERROR("LOCKING",