From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, lukas@wunner.de, ak@linux.intel.com,
hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
namhyung@kernel.org, mingo@kernel.org, dsahern@gmail.com,
eranian@google.com, a.p.zijlstra@chello.nl,
adrian.hunter@intel.com, jolsa@kernel.org
Subject: [tip:perf/core] perf build: Fix single target build dependency check
Date: Thu, 25 Jun 2015 00:56:09 -0700 [thread overview]
Message-ID: <tip-8e55735150934f9ab2ce8a8005626e5693a6b61d@git.kernel.org> (raw)
In-Reply-To: <1434977452-32520-4-git-send-email-jolsa@kernel.org>
Commit-ID: 8e55735150934f9ab2ce8a8005626e5693a6b61d
Gitweb: http://git.kernel.org/tip/8e55735150934f9ab2ce8a8005626e5693a6b61d
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Mon, 22 Jun 2015 14:50:52 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 22 Jun 2015 11:27:09 -0300
perf build: Fix single target build dependency check
Currently if we build a single target like:
$ touch util/map.c && make util/map.o
It will not rebuild util/map.o if it already exists and util/map.c is
modified.
The reason is that the top-level 'Makefile' processes util/map.o as an
implicit rule and if util/map.o exists make considers the 'util/map.o'
target as done and will not nest into Makefile.perf.
Adding FORCE for '%', because that's what we want to nest into
Makefile.perf for any target.
Adding Makefile into phony targets, because make tries to rebuild it and
it's also resolved as '%' target.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1434977452-32520-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index d31a7bb..480546d 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -83,8 +83,8 @@ build-test:
#
# All other targets get passed through:
#
-%:
+%: FORCE
$(print_msg)
$(make)
-.PHONY: tags TAGS
+.PHONY: tags TAGS FORCE Makefile
prev parent reply other threads:[~2015-06-25 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 12:50 [PATCH 0/3] perf tool: Build fixes Jiri Olsa
2015-06-22 12:50 ` [PATCH 1/3] perf tests: Add testing for Makefile.perf Jiri Olsa
2015-06-25 7:55 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-22 12:50 ` [PATCH 2/3] perf tests: Add test for make install with prefix Jiri Olsa
2015-06-25 7:55 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-06-22 12:50 ` [PATCH 3/3] perf build: Fix single target build dependency check Jiri Olsa
2015-06-25 7:56 ` tip-bot for Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8e55735150934f9ab2ce8a8005626e5693a6b61d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®