From: "tip-bot for Luis R. Rodriguez" <lrodriguez@atheros.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
joonas.viskari@atheros.com, lrodriguez@atheros.com,
allen.kao@atheros.com, alan@lxorguk.ukuu.org.uk,
roman.gezikov@atheros.com, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/cleanups] x86: Fix mrst sparse complaints
Date: Sat, 7 May 2011 09:46:05 GMT [thread overview]
Message-ID: <tip-8fab6af2156c0100f953fd61f4e0b2f82c9776dc@git.kernel.org> (raw)
In-Reply-To: <1304719209-26913-1-git-send-email-lrodriguez@atheros.com>
Commit-ID: 8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Gitweb: http://git.kernel.org/tip/8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Author: Luis R. Rodriguez <lrodriguez@atheros.com>
AuthorDate: Fri, 6 May 2011 15:00:09 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 7 May 2011 10:52:30 +0200
x86: Fix mrst sparse complaints
Fix these Sparse complaints:
CHECK arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Roman Gezikov <roman.gezikov@atheros.com>
Cc: Joonas Viskari <joonas.viskari@atheros.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Allen Kao <allen.kao@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Link: http://lkml.kernel.org/r/1304719209-26913-1-git-send-email-lrodriguez@atheros.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/platform/mrst/mrst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
return 0;
}
-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
{
sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
apbt_time_init();
}
-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
{
if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;
prev parent reply other threads:[~2011-05-07 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 22:00 [PATCH] x86: fix " Luis R. Rodriguez
2011-05-06 22:31 ` Alan Cox
2011-05-07 9:46 ` tip-bot for Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8fab6af2156c0100f953fd61f4e0b2f82c9776dc@git.kernel.org \
--to=lrodriguez@atheros.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=allen.kao@atheros.com \
--cc=hpa@zytor.com \
--cc=joonas.viskari@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=roman.gezikov@atheros.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome